Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go link: use external linker when in race mode #3370

Merged
merged 1 commit into from
Nov 30, 2022
Merged

go link: use external linker when in race mode #3370

merged 1 commit into from
Nov 30, 2022

Commits on Nov 30, 2022

  1. go link: use external linker when in race mode 

    As of clang 15.0.3 (via zig v0.10), when building with `race = "on"` on
x86_64 Linux, we observe the following:

    runtime/cgo(.text): relocation target memset not defined

From my past experience, reporting a Go linker error when the external
linker works has a high chance to get the ticket closed as unactionable;
so it makes sense to just use an external linker, when it works.

Also, do not set the flag if external cpp toolchain is not set up.
    @motiejus
    motiejus committed Nov 30, 2022
    Configuration menu
    Copy the full SHA
    a22907b View commit details
    Browse the repository at this point in the history