Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runfiles: port phst/runfiles to rules_go #3205

Merged
merged 5 commits into from
Nov 6, 2022
Merged

runfiles: port phst/runfiles to rules_go #3205

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1f0bd83
runfiles: port phst/runfiles to rules_go
sluongng Jun 17, 2022
82a8902
Consistently take in / and emit \ on Windows
fmeum Jul 27, 2022
3b1c1fb
Fix runfiles tests on Windows
fmeum Jul 27, 2022
8b4fe32
Add deprecation note to old `Runfiles` method
fmeum Nov 6, 2022
742afcb
Address review comments
fmeum Nov 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add deprecation note to old Runfiles method
  • Loading branch information
@fmeum
fmeum committed Nov 6, 2022
commit 8b4fe3207488483a45b5a5b2fe686aad692473ec
4 changes: 4 additions & 0 deletions go/tools/bazel/runfiles.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,10 @@ const (
// Runfile may be called from tests invoked with 'bazel test' and
// binaries invoked with 'bazel run'. On Windows,
// only tests invoked with 'bazel test' are supported.
//
// Deprecated: Use github.com/bazelbuild/rules_go/go/tools/bazel/runfiles
// instead for cross-platform support matching the behavior of the
// Bazel-provided runfiles libraries.
func Runfile(path string) (string, error) {
// Search in working directory
if _, err := os.Stat(path); err == nil {
Expand Down