link: make package conflicts into errors instead of warnings #2730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've promised to do this for more than two years, and the time has finally come. If more than one copy of a package with the same package path is provided to the linker, the GoLink action now reports an error. Distinct packages (for example, from multiple vendor directories) may be disambiguated with the importmap attribute. Fixes bazelbuild#1374
jayconrod
pushed a commit
to jayconrod/rules_go
that referenced
this pull request
Feb 16, 2021
The Go 1.16 linker appears stricter about fingerprinting. This test no longer works, but the behavior being tested was never supported. Sync with the test on master, which always expects an error.
jayconrod
pushed a commit
that referenced
this pull request
Feb 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've promised to do this for more than two years, and the time has
finally come.
If more than one copy of a package with the same package path is
provided to the linker, the GoLink action now reports an
error. Distinct packages (for example, from multiple vendor
directories) may be disambiguated with the importmap attribute.
Fixes #1374