add importpath_aliases to go_proto_library #2608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR seems incomplete? It doesn't actually implement |
|
@jayconrod in Line 19 of |
|
Im pretty new to rules_go but i think it works out of the box because |
jayconrod
reviewed
Aug 18, 2020
|
np! @jayconrod responded to your comments! |
jayconrod
pushed a commit
to jayconrod/rules_go
that referenced
this pull request
Aug 21, 2020
This reverts commit 631e26b. rules_go CI started failing after bazelbuild#2608 was merged. For bazelbuild/bazel#11885
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug fix
What does this PR do? Why is it needed?
It allows go_proto_library to accept
importpath_aliasesas an argument. It is needed because gazelle generates go_proto_library rules that have importpath_aliases as an argument.Which issues(s) does this PR fix?
Fixes #2358