Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.4.0] Automatically ignore vendor dir for finding packages #23919

Merged

Conversation

meteorcloudy
Copy link
Member

@meteorcloudy meteorcloudy commented Oct 9, 2024

  • Adding --vendor_dir to ignored package prefixes as if it's added in the .bazelignore file.
  • This allows users to do bazel build //... after vendoring external deps in the source root without manually adding the vendor dir in .bazelignore.

Fixes #23521

Closes #23771.

PiperOrigin-RevId: 680994986
Change-Id: I9c8b76ca20b9060232dfe05460a8fc857c92e93f

Backporting d42301b

- Adding `--vendor_dir` to ignored package prefixes as if it's added in the `.bazelignore` file.
- This allows users to do `bazel build //...` after vendoring external deps in the source root without manually adding the vendor dir in `.bazelignore`.

Fixes bazelbuild#23521

Closes bazelbuild#23771.

PiperOrigin-RevId: 680994986
Change-Id: I9c8b76ca20b9060232dfe05460a8fc857c92e93f
@meteorcloudy meteorcloudy requested a review from a team as a code owner October 9, 2024 13:06
@github-actions github-actions bot added awaiting-review PR is awaiting review from an assigned reviewer team-Configurability platforms, toolchains, cquery, select(), config transitions team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. labels Oct 9, 2024
@meteorcloudy meteorcloudy requested review from Wyverald and removed request for a team October 9, 2024 13:28
@keertk keertk enabled auto-merge October 9, 2024 13:40
@keertk keertk added this pull request to the merge queue Oct 9, 2024
@meteorcloudy meteorcloudy removed this pull request from the merge queue due to a manual request Oct 9, 2024
@meteorcloudy meteorcloudy merged commit cb5bc05 into bazelbuild:release-7.4.0 Oct 9, 2024
50 checks passed
@github-actions github-actions bot removed the awaiting-review PR is awaiting review from an assigned reviewer label Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-Configurability platforms, toolchains, cquery, select(), config transitions team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants