Migrate Local Notification #734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bannzai
commented
Dec 18, 2022
| return reminderNotificationIdentifierOffset + groupIndex + hour + minute + pillNumberIntoPillSheet; | ||
| } | ||
|
|
||
| // UseCase: |
There was a problem hiding this comment.
UseCaseを並べていたが、やっぱり事前登録であるのが複雑だな。と思ってネックになっている。
この処理の中に途中で休薬がある場合で休薬通知がOFFの場合、等の分岐を入れることも考えると、UseCaseはこれよりも増えて複雑になる。
また、LocalNotificationのAPIがきちんとした形式なら良いが、通知が登録できなかった場合のエラーやIDが重複していた場合のエラーなどの区別をする術がない(existLocalNotificationIDみたいなのが無い)のでちょっと厳しいな。って思ったのでやめる
|
マージしてrevert |
This was referenced Jul 15, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Abstract
LocalNotificationの検討その2
ref: #558
けっかてきにはまたあきらめた
Why
Links
Checked