New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SignIn method #489

Merged

bannzai merged 8 commits into main from fix/function/signin

Jan 30, 2022

Owner

bannzai commented Jan 30, 2022

Abstract

2重でSignInを叩く可能性を減らす
本来であればUserがいて欲しい場面であれば、確実にキャッシュのデータを引くようにする

Why

2重でSignInを叩かれる可能性を減らす
あと初期のコードでCachedUserを手に入れる場合とSignInをするコードをまとめて一緒くたに実行していたが、わかりづらいのでやめる

Links

Checked

Analyticsのログを入れたか
境界値に対してのUnitTestを書いた
パターン分岐が発生するWidgetに対してWidgetTestを書いた
リリースノートを追加した

bannzai added 8 commits

January 30, 2022 15:03


          Remove unnecessay signin

7367ce6


          ♻️ remove unnecesary import

c827fdb


          ♻️ Rename function

c996855


          ♻️ Without SignIN

9e5ed20


          ♻️ Without SignIn

ed5fa55


          remove unnecessary import

25d4006


          📝 Without SignIn

e79b201


          ♻️ remove unnecessary import

95d5109

bannzai marked this pull request as ready for review

January 30, 2022 08:03

bannzai merged commit f57051d into main

bannzai deleted the fix/function/signin branch

January 30, 2022 08:04

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet