Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert Remove AdMob #1052

Merged
merged 4 commits into from
Nov 26, 2023
Merged

Revert Remove AdMob #1052

merged 4 commits into from
Nov 26, 2023

Conversation

bannzai
Copy link
Owner

@bannzai bannzai commented Nov 26, 2023

Abstract

AdMobが復活したのでもう一回チャレンジ

Why

Links

Checked

  • Analyticsのログを入れたか
  • 境界値に対してのUnitTestを書いた
  • パターン分岐が発生するWidgetに対してWidgetTestを書いた

@bannzai
Revert "Merge pull request #1018 from bannzai/remove/lib/admob"
10ea5af 
This reverts commit 8b8657e, reversing
changes made to 2f20863.

# Conflicts:
#	ios/Podfile.lock
#	lib/entrypoint.dart
#	pubspec.yaml
@bannzai
Remove duplicated dep
45b6793
@bannzai
🐚 pod install
cf0a931
@bannzai
Use await
da6caaa
@bannzai bannzai merged commit 2c84041 into main Nov 26, 2023
3 of 4 checks passed
@bannzai bannzai deleted the revert/remove/lib/admob branch November 26, 2023 11:39
@bannzai bannzai mentioned this pull request Dec 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bannzai