Merge pull request lonnieezell#366 from MGatner/username-constraint

Username Constraints

src/Authentication/Passwords/ValidationRules.php

@@ -69,7 +69,7 @@ protected function buildUserFromRequest()
     {
         $fields = $this->prepareValidFields();
 
-        $data = service('request')->getPost($fields);
+        $data = array_filter(service('request')->getPost($fields));
 
         return new User($data);
     }

src/Controllers/AuthController.php

@@ -153,7 +153,7 @@ public function attemptRegister()
 		// Validate here first, since some things,
 		// like the password, can only be validated properly here.
 		$rules = [
-			'username'  	=> 'required|alpha_numeric_space|min_length[3]|is_unique[users.username]',
+			'username'  	=> 'required|alpha_numeric_space|min_length[3]|max_length[30]|is_unique[users.username]',
 			'email'			=> 'required|valid_email|is_unique[users.email]',
 			'password'	 	=> 'required|strong_password',
 			'pass_confirm' 	=> 'required|matches[password]',

src/Models/UserModel.php

@@ -21,7 +21,7 @@ class UserModel extends Model
 
     protected $validationRules = [
         'email'         => 'required|valid_email|is_unique[users.email,id,{id}]',
-        'username'      => 'required|alpha_numeric_punct|min_length[3]|is_unique[users.username,id,{id}]',
+        'username'      => 'required|alpha_numeric_punct|min_length[3]|max_length[30]|is_unique[users.username,id,{id}]',
         'password_hash' => 'required',
     ];
     protected $validationMessages = [];

src/Test/Fakers/UserFaker.php

@@ -17,7 +17,7 @@ public function fake(Generator &$faker): User
 	{
 		return new User([
 			'email'    => $faker->email,
-			'username' => implode('_', $faker->words),
+			'username' => $faker->userName,
 			'password' => bin2hex(random_bytes(16)),
 		]);
 	}