Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add node name flag to serve command #4410

Merged
merged 13 commits into from
Sep 16, 2024
Merged

Conversation

frrist
Copy link
Member

@frrist frrist commented Sep 12, 2024

cmd/cli/serve/serve.go Outdated Show resolved Hide resolved
Base automatically changed from frrist/fix/migration-3_4 to main September 12, 2024 20:46
@frrist frrist mentioned this pull request Sep 12, 2024
cmd/cli/serve/serve.go Outdated Show resolved Hide resolved
cmd/cli/serve/serve.go Outdated Show resolved Hide resolved
Copy link
Member

@wdbaruni wdbaruni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but please address the comments before merging

@frrist frrist merged commit fa041b9 into main Sep 16, 2024
4 checks passed
@frrist frrist deleted the frrist/cli/node-name-flag-serve branch September 16, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow users to set the bacalhau node name when starting a bacalhau server.
2 participants