Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix example program #32

Closed
baalexander opened this issue Oct 25, 2011 · 0 comments
Closed

Fix example program #32

baalexander opened this issue Oct 25, 2011 · 0 comments

Comments

@baalexander
Copy link
Owner

When running node example/client-server.js, some of the getters are called before the setters. For example, getArray returns null even though setArray is called before with a value.

Putting the getArray code in the callback for the setArray ended up with the callback never getting called. It's possible the callback was never getting called.

// Nest the getter in the callback of the setter (getter does not currently get called)
client.methodCall('setArray', [['value1', 'value2']], function (error, value) {
  client.methodCall('getArray', null, function (error, value) {
    console.log('Get Array Response: ' + value)
  })
})
baalexander added a commit that referenced this issue Oct 27, 2011
A fault in the form `<methodResponse><fault></value></fault></methodResponse>`
was not calling the callback properly since no param fields were being hit. This
problem was noticed when trying to chain functions in the example code. A test
case was added to prevent regression.

See Issue #32.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant