Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SPILL_QUEUE_CAPACITY config property can now be set as all lowercase #1852

Merged
merged 2 commits into from
Mar 22, 2024
Merged

SPILL_QUEUE_CAPACITY config property can now be set as all lowercase #1852

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
875d626
SPILL_QUEUE_CAPACITY config property can now be declared as all lower…
akuzin1 Mar 20, 2024
7f7471d
Merge branch 'master' into spill_queue_capacity_bc
akuzin1 Mar 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
SPILL_QUEUE_CAPACITY config property can now be declared as all lower… 
…case as well
  • Loading branch information
@akuzin1
akuzin1 committed Mar 20, 2024
commit 875d6268a7525b0c558ed2b834f9581a46c9bb4c
7 changes: 5 additions & 2 deletions ...deration-sdk/src/main/java/com/amazonaws/athena/connector/lambda/data/S3BlockSpiller.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@
import com.fasterxml.jackson.databind.ObjectMapper;
import com.google.common.io.ByteStreams;
import org.apache.arrow.vector.types.pojo.Schema;
import org.apache.commons.lang3.StringUtils;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

Expand Down Expand Up @@ -499,8 +500,10 @@ private void safeClose(AutoCloseable block)
private ThreadPoolExecutor makeAsyncSpillPool(SpillConfig config)
{
int spillQueueCapacity = config.getNumSpillThreads();
if (configOptions.get(SPILL_QUEUE_CAPACITY) != null) {
spillQueueCapacity = Integer.parseInt(configOptions.get(SPILL_QUEUE_CAPACITY));

String capacity = StringUtils.isNotBlank(configOptions.get(SPILL_QUEUE_CAPACITY)) ? configOptions.get(SPILL_QUEUE_CAPACITY) : configOptions.get(SPILL_QUEUE_CAPACITY.toLowerCase());
if (capacity != null) {
spillQueueCapacity = Integer.parseInt(capacity);
logger.debug("Setting Spill Queue Capacity to {}", spillQueueCapacity);
}

Expand Down