Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: Support for environment variables in the HPO #3614

Merged
merged 1 commit into from
Jan 27, 2023
Merged

feature: Support for environment variables in the HPO #3614

merged 1 commit into from
Jan 27, 2023

Conversation

repushko
Copy link
Collaborator

Description of changes:
We know support the environment variables in the HPO. They already exist in the BaseEstimator class, so we'll just use them into our code.

Testing done:
Unit tests are extended.

Merge Checklist

General

  • I have read the CONTRIBUTING doc
  • I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
  • I used the commit message format described in CONTRIBUTING
  • I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  • I have checked that my tests are not configured for a specific region or account (if appropriate)
  • I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@repushko repushko requested a review from a team as a code owner January 26, 2023 16:26
@repushko repushko requested review from claytonparnell and removed request for a team January 26, 2023 16:26
@repushko repushko mentioned this pull request Jan 26, 2023
Closed
9 tasks
trajanikant
trajanikant reviewed Jan 26, 2023
View reviewed changes
Copy link
Contributor

@trajanikant trajanikant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

\bot run all

trajanikant
trajanikant reviewed Jan 26, 2023
View reviewed changes
Copy link
Contributor

@trajanikant trajanikant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/bot run all

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 47c86ae
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 47c86ae
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 47c86ae
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 47c86ae
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@codecov-commenter
Copy link

codecov-commenter commented Jan 26, 2023 •
edited
Loading

Codecov Report

Merging #3614 (47c86ae) into master (25c49d4) will decrease coverage by 0.80%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##           master    #3614      +/-   ##
==========================================
- Coverage   89.59%   88.80%   -0.80%     
==========================================
  Files         968      227     -741     
  Lines       89600    22161   -67439     
==========================================
- Hits        80279    19680   -60599     
+ Misses       9321     2481    -6840
Impacted Files Coverage Δ
src/sagemaker/tuner.py 93.56% <50.00%> (ø)
src/sagemaker/session.py 74.12% <100.00%> (ø)
....9/site-packages/sagemaker/experiments/__init__.py
...ib/python3.9/site-packages/sagemaker/amazon/ntm.py
...ite-packages/sagemaker/apiutils/_boto_functions.py
...thon3.8/site-packages/sagemaker/lineage/context.py
...n3.8/site-packages/sagemaker/workflow/functions.py
...b/python3.7/site-packages/sagemaker/local/utils.py
...3.8/site-packages/sagemaker/serverless/__init__.py
...hon3.8/site-packages/sagemaker/sparkml/__init__.py
... and 1187 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 47c86ae
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

trajanikant
trajanikant reviewed Jan 26, 2023
View reviewed changes
Copy link
Contributor

@trajanikant trajanikant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/bot run slow-tests, notebook-tests

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 47c86ae
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 47c86ae
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

trajanikant
trajanikant reviewed Jan 26, 2023
View reviewed changes
Copy link
Contributor

@trajanikant trajanikant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/bot run notebook-tests

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 47c86ae
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

trajanikant
trajanikant reviewed Jan 27, 2023
View reviewed changes
Copy link
Contributor

@trajanikant trajanikant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/bot run slow-tests

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 47c86ae
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

trajanikant
trajanikant reviewed Jan 27, 2023
View reviewed changes
Copy link
Contributor

@trajanikant trajanikant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/bot run slow-tests

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 47c86ae
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

trajanikant
trajanikant reviewed Jan 27, 2023
View reviewed changes
Copy link
Contributor

@trajanikant trajanikant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/bot run slow-tests

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 47c86ae
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@knikure knikure changed the title feature: support for environment variables in the HPO feature: Support for environment variables in the HPO Jan 27, 2023
@knikure knikure merged commit cee70dc into aws:master Jan 27, 2023
This was referenced Jan 27, 2023
Closed
Closed
Closed
@tim-finnigan tim-finnigan mentioned this pull request Jan 27, 2023
Closed
@repushko repushko deleted the hpo_env_variables_support branch January 30, 2023 12:10
@DougTrajano DougTrajano mentioned this pull request Feb 2, 2023
Closed
@timxieICN timxieICN mentioned this pull request Mar 2, 2023
Closed
JoseJuan98 pushed a commit to JoseJuan98/sagemaker-python-sdk that referenced this pull request Mar 4, 2023
@repushko @JoseJuan98
feature: Support for environment variables in the HPO (aws#3614)
9b5a301 
Co-authored-by: Anton Repushko <[email protected]>
nmadan pushed a commit to nmadan/sagemaker-python-sdk that referenced this pull request Apr 18, 2023
@repushko
feature: Support for environment variables in the HPO (aws#3614)
04255dd 
Co-authored-by: Anton Repushko <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trajanikant trajanikant trajanikant left review comments

@iaroslav-ai iaroslav-ai iaroslav-ai approved these changes

@knikure knikure knikure approved these changes

@claytonparnell claytonparnell Awaiting requested review from claytonparnell claytonparnell is a code owner automatically assigned from aws/sagemaker-ml-frameworks

Assignees

@trajanikant trajanikant

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@repushko @sagemaker-bot @codecov-commenter @iaroslav-ai @trajanikant @knikure