Fix copying of Config.LogHTTPBody attribute in Config.Copy() method #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The attribute was omitted from copying into the new instance. Merge method is simplified to avoid unnecessary nil checks for newcfg. Both method Copy and Merge are now covered with unit tests.
|
Good catch, thank you for submitting the PR @mrekucci. Looks good, going to merge this in. Great to have the extra unit tests. |
jasdel
added a commit
that referenced
this pull request
Jun 4, 2015
Fix copying of Config.LogHTTPBody attribute in Config.Copy() method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The attribute was omitted from copying into the new instance.
Merge method is simplified to avoid unnecessary nil checks for newcfg.
Both method Copy and Merge are now covered with unit tests.