Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add data-testid to components. Closes #444 #467

Merged
merged 9 commits into from
Dec 17, 2021
Merged

feat: Add data-testid to components. Closes #444 #467

merged 9 commits into from
Dec 17, 2021

Conversation

jessieweiyi
Copy link
Contributor

Issue #, if available:

#444

Description of changes:

Allow developers to set custom data-testid to NorthStar components to facilitate automated testing.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@jessieweiyi jessieweiyi marked this pull request as ready for review December 17, 2021 04:54
Copy link
Member

@cogwirrel cogwirrel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Jessie! This is exactly what we need! 😁

@jessieweiyi jessieweiyi merged commit d7244a1 into main Dec 17, 2021
@jessieweiyi jessieweiyi deleted the testid branch December 17, 2021 23:30
@aws-prototyping-bot
Copy link
Collaborator

🎉 This PR is included in version 1.3.12 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants