-
Notifications
You must be signed in to change notification settings - Fork 598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix _NET_CURRENT_DESKTOP ClientMessage handling #3237
Conversation
This was broken in commit c5202a4 by adding an extra string to the Lua stack. Hence, the offset -1 now referred to the string and not the tag. Fixes: awesomeWM#3236 Signed-off-by: Uli Schlachter <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #3237 +/- ##
==========================================
+ Coverage 88.21% 89.00% +0.78%
==========================================
Files 662 704 +42
Lines 44962 51089 +6127
==========================================
+ Hits 39662 45470 +5808
- Misses 5300 5619 +319
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be great to have this covered with some test(s).
@Elv13
Do you think this can be done easily?
Do we need to close/reopen this to make codecov run again? It seems it just randomly crashed... |
This was broken in commit c5202a4 by adding an extra string to the Lua stack. Hence, the offset -1 now referred to the string and not the tag. Fixes: awesomeWM#3236 Signed-off-by: Uli Schlachter <[email protected]>
This was broken in commit c5202a4 by adding an extra string to the Lua stack. Hence, the offset -1 now referred to the string and not the tag. Fixes: awesomeWM#3236 Signed-off-by: Uli Schlachter <[email protected]>
This was broken in commit c5202a4 by adding an extra string
to the Lua stack. Hence, the offset -1 now referred to the string and
not the tag.
Fixes: #3236
Signed-off-by: Uli Schlachter [email protected]