dbus.c: Handle invalid bus names #2763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the following code produce a Lua error instead of crashing
AwesomeWM:
dbus.emit_signal("foobar", "/", "org.awesome.SomeInterface", "method",
"s", "string argument")
The crash looked like this:
dbus[710]: arguments to dbus_connection_send() were incorrect, assertion
"connection != NULL" failed in file dbus/dbus-connection.c line 3307.
This is normally a bug in some application using the D-Bus library.
Signed-off-by: Uli Schlachter <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #2763 +/- ##
==========================================
- Coverage 86.21% 86.21% -0.01%
==========================================
Files 541 541
Lines 36953 36955 +2
==========================================
+ Hits 31859 31860 +1
- Misses 5094 5095 +1
|
actionless
approved these changes
May 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the following code produce a Lua error instead of crashing
AwesomeWM:
dbus.emit_signal("foobar", "/", "org.awesome.SomeInterface", "method",
"s", "string argument")
The crash looked like this:
dbus[710]: arguments to dbus_connection_send() were incorrect, assertion
"connection != NULL" failed in file dbus/dbus-connection.c line 3307.
This is normally a bug in some application using the D-Bus library.
Signed-off-by: Uli Schlachter [email protected]