Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

awesomerc.lua: show hotkeys popup on mouse screen. fixes: #2583, fixes: #2585 #2586

Merged
merged 3 commits into from
Jan 14, 2019

Conversation

Sorky
Copy link
Contributor

@Sorky Sorky commented Jan 14, 2019

Alternative fix for hotkey_popup via awful menu showing on wrong screen

#2583
#2527

@Sorky Sorky mentioned this pull request Jan 14, 2019
@codecov
Copy link

codecov bot commented Jan 14, 2019

Codecov Report

Merging #2586 into master will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2586      +/-   ##
==========================================
+ Coverage   84.65%   84.68%   +0.02%     
==========================================
  Files         496      496              
  Lines       33738    33738              
==========================================
+ Hits        28562    28570       +8     
+ Misses       5176     5168       -8
Flag Coverage Δ
#c_code 73.65% <ø> (+0.11%) ⬆️
#functionaltests 70.96% <ø> (ø) ⬆️
#lua53 84.68% <ø> (+0.02%) ⬆️
#samples 74.65% <ø> (ø) ⬆️
#themes 49.77% <ø> (+0.01%) ⬆️
#unittests 58.17% <ø> (ø) ⬆️
Impacted Files Coverage Δ
lib/awful/hotkeys_popup/init.lua 100% <ø> (ø) ⬆️
spawn.c 86.51% <0%> (+3.72%) ⬆️

actionless
actionless previously approved these changes Jan 14, 2019
@actionless
Copy link
Member

actionless
actionless previously approved these changes Jan 14, 2019
@actionless
Copy link
Member

marking for manual merge since it's requiring squashing before merge

Alternative fix for hotkey_popup via awful menu showing on wrong screen
@Elv13
Copy link
Member

Elv13 commented Jan 14, 2019

Rebased / squashed

@Elv13
Copy link
Member

Elv13 commented Jan 14, 2019

I added a commit to fix the documentation generation

@actionless actionless changed the title Update awesomerc.lua awesomerc.lua: show hotkeys popup on mouse screen. fixes: #2583, fixes: #2585 Jan 14, 2019
@Elv13 Elv13 merged commit 708e522 into awesomeWM:master Jan 14, 2019
@Elv13
Copy link
Member

Elv13 commented Jan 14, 2019

thanks

@actionless
Copy link
Member

thanks for looking into this, @Sorky !

@Sorky
Copy link
Contributor Author

Sorky commented Jan 14, 2019

And thank you both for the education

@Sorky Sorky deleted the patch-3 branch January 14, 2019 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants