Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile: run CMake with CMAKE_ARGS defined #2567

Merged
merged 3 commits into from
Jan 15, 2019

Conversation

blueyed
Copy link
Member

@blueyed blueyed commented Jan 9, 2019

This ensures to re-run CMake when using something like:

make check-unit CMAKE_ARGS="-DSTRICT_TESTS=true -DDO_COVERAGE=1"

This ensures to re-run CMake when using something like:

> CMAKE_ARGS="-DSTRICT_TESTS=true -DDO_COVERAGE=1 make check-unit
@codecov
Copy link

codecov bot commented Jan 9, 2019

Codecov Report

Merging #2567 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2567   +/-   ##
=======================================
  Coverage   84.65%   84.65%           
=======================================
  Files         496      496           
  Lines       33738    33738           
=======================================
  Hits        28562    28562           
  Misses       5176     5176
Flag Coverage Δ
#c_code 73.53% <ø> (ø) ⬆️
#functionaltests 70.96% <ø> (ø) ⬆️
#lua53 84.65% <ø> (ø) ⬆️
#samples 74.65% <ø> (ø) ⬆️
#themes 49.77% <ø> (+0.01%) ⬆️
#unittests 58.17% <ø> (ø) ⬆️

@blueyed blueyed changed the title Makefile: run CMake with CMAKE_ARGS defined [RFC] Makefile: run CMake with CMAKE_ARGS defined Jan 9, 2019
Makefile Show resolved Hide resolved
@blueyed blueyed changed the title [RFC] Makefile: run CMake with CMAKE_ARGS defined Makefile: run CMake with CMAKE_ARGS defined Jan 12, 2019
@mergify mergify bot merged commit 8fe06f9 into awesomeWM:master Jan 15, 2019
@blueyed blueyed deleted the cmake-args branch January 15, 2019 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants