Partly fix removal of systray from a wibox #1646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds new code so that we can count how often a specific widget is visible inside of all widget hierarchies. Signed-off-by: Uli Schlachter <[email protected]>
This commit changes the systray widget, wibox.drawable and the C code to fix the following bug: When the systray widget is removed from a drawable without being moved somewhere else, the systray stayed visible. This was because the systray is not drawn by awesome, but only placed. When the widget is no longer "drawn", it stays wherever it was placed last. This change works by detecting the situation when the systray is removed. Then, the C code is specifically told to remove the systray window from the drawable. Note that this is only a partial fix. This change works correctly when the widget is removed completely, because it is no longer placed by its parent widget. However, for example, when you do wibox.widget.systray().visible = false, the effect is just that the systray widget gets size 0x0. This is not really visible, but as far as this change is concerned, the widget is still part of the drawable. Signed-off-by: Uli Schlachter <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #1646 +/- ##
==========================================
+ Coverage 81.73% 81.78% +0.04%
==========================================
Files 297 297
Lines 18335 18400 +65
==========================================
+ Hits 14987 15049 +62
- Misses 3348 3351 +3
Continue to review full report at Codecov.
|
Widgets with width or height zero cannot really be counted as visible, so do not do so. Signed-off-by: Uli Schlachter <[email protected]>
I spent way too much time trying to figure out why setting "visible" to false did not work... Signed-off-by: Uli Schlachter <[email protected]>
Elv13
approved these changes
Mar 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the systray widget, wibox.drawable and the C code to
fix the following bug: When the systray widget is removed from a
drawable without being moved somewhere else, the systray stayed visible.
This was because the systray is not drawn by awesome, but only placed.
When the widget is no longer "drawn", it stays wherever it was placed
last.
This change works by detecting the situation when the systray is
removed. Then, the C code is specifically told to remove the systray
window from the drawable.
Note that this is only a partial fix. This change works correctly when
the widget is removed completely, because it is no longer placed by its
parent widget. However, for example, when you do
wibox.widget.systray().visible = false, the effect is just that the
systray widget gets size 0x0. This is not really visible, but as far as
this change is concerned, the widget is still part of the drawable.
[Should
wibox.hierarchyto be changed so that it does not count widgets with width 0 or height 0?]