Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add beautiful property to control busy cursor during spawn #1613

Merged
merged 1 commit into from
Mar 17, 2017

Conversation

SammysHP
Copy link
Contributor

@SammysHP SammysHP commented Mar 1, 2017

No description provided.


local app_starting = {}

local cursor_waiting = "watch"

--- Show busy mouse cursor during spawn.
-- @beautiful beautiful.enable_spawn_cursor
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+-- @beautiful beautiful.enable_spawn_cursor
+-- @tparam[opt=true] boolean enable_spawn_cursor

local function update_cursor()
if #app_starting > 0 then
if #app_starting > 0 and (beautiful.enable_spawn_cursor or beautiful.enable_spawn_cursor == nil) then
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beautiful.enable_spawn_cursor ~= false will do

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure! Too late and had too much work today. :)

@codecov
Copy link

codecov bot commented Mar 1, 2017

Codecov Report

Merging #1613 into master will increase coverage by 0.02%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1613      +/-   ##
==========================================
+ Coverage   80.66%   80.68%   +0.02%     
==========================================
  Files         278      278              
  Lines       17353    17358       +5     
==========================================
+ Hits        13997    14005       +8     
+ Misses       3356     3353       -3
Flag Coverage Δ
#functionaltests 64.35% <100%> (+0.03%)
#samples 63.12% <ø> (ø)
#unittests 73.79% <ø> (ø)
Impacted Files Coverage Δ
lib/awful/startup_notification.lua 100% <100%> (ø)
lib/awful/layout/suit/magnifier.lua 68.67% <0%> (+5.38%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f34e69...2f0d0e3. Read the comment docs.

@blueyed
Copy link
Member

blueyed commented Mar 1, 2017

What about controlling the cursor being used (a default of "watch" then)?
Using false would then use "left_ptr".

@SammysHP
Copy link
Contributor Author

SammysHP commented Mar 1, 2017

@blueyed I had the same idea but couldn't think of any other cursor that a user might want to use. That should be changed in the cursor theme.

@Elv13
Copy link
Member

Elv13 commented Mar 1, 2017

Why not, but I think this belong to it's own beautiful variables. Something like spawn_cursor. But this means changing the name to spawn_cursor_enabled to have them both in the same namespace

@Elv13
Copy link
Member

Elv13 commented Mar 12, 2017

Will someone ever use another cursor than the current one or left_ptr? After thinking about it, I am not sure anybody will ever use such option. Did I miss something? Otherwise, if there is no further activity, I will merge this as-is in 2 days.

@Elv13 Elv13 added this to the next: pull requests to be merged soon milestone Mar 12, 2017
@Elv13 Elv13 merged commit b73f9e9 into awesomeWM:master Mar 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants