Fix toggle without search query #863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the conditional for `data-selected-resources` element to render always, and set a `hidden` css class if there are: * no search params defined in the resource AND * no filters present AND * 1 or none available_view_types Also added the `authenticity_token` to the permitted params as it was consistently showing up in the logs. ``` Unpermitted parameter: :authenticity_token ```
|
Code Climate has analyzed commit 32cf0e2 and detected 0 issues on this pull request. View more on Code Climate. |
Codecov Report
@@ Coverage Diff @@
## main #863 +/- ##
=======================================
Coverage 93.86% 93.86%
=======================================
Files 457 457
Lines 8325 8325
=======================================
Hits 7814 7814
Misses 511 511
Continue to review full report at Codecov.
|
adrianthedev
approved these changes
Apr 25, 2022
| @@ -32,7 +32,7 @@ From the root directory you can run `bin/dev` and that will start a foreman proc | |||
|
|
|||
| ## Seeding the database for local development | |||
|
|
|||
| Run `AVO_ADMIN_PASSWORD=secret bin/rails db:seed` to seed the database with dummy data and create a user for yourself with the email `admin@avohq.io` and password `secret`. | |||
| Run `AVO_ADMIN_PASSWORD=secret bin/rails db:seed` to seed the database with dummy data and create a user for yourself with the email `avo@avohq.io` and password `secret`. | |||
| <% end %> | ||
| </div> | ||
| <% end %> | ||
| <div class="flex flex-col xs:flex-row xs:justify-between space-y-2 xs:space-y-0 py-4 <%= 'hidden' if @resource.search_query.nil? && @filters.empty? && available_view_types.count <= 1 %>" |
There was a problem hiding this comment.
This was a remnant from where we had more than two divs in the panel body and we had a space-y-SOMETHING as a parent. So I went and not render this div at all in those scenarios. It's not the case anymore and we can use hidden.
schmidtg
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix the JS error when selecting a checkbox on an Index page that has no search query defined in the resource.
Fixes # (861)
Manual review steps
data-selected-resourceselement is populated with IDs that were selected.