Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop Node.js 16, upgrade minimal 18 and 20, test 21 #3251

Merged
merged 5 commits into from
Oct 23, 2023
Merged

Drop Node.js 16, upgrade minimal 18 and 20, test 21 #3251

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
85e49d8
Drop support for Node.js 16
novemberborn Oct 22, 2023
1f93d7f
Change expected Node.js 18 to 18.18
novemberborn Oct 22, 2023
dbfba59
Change expected Node.js 20 to 20.8
novemberborn Oct 22, 2023
a10c989
Add Node.js 21 to the test matrix
novemberborn Oct 22, 2023
922bc91
Change snapshot tests to compare decompressed bitstreams
novemberborn Oct 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Change expected Node.js 20 to 20.8
  • Loading branch information
@novemberborn
novemberborn committed Oct 22, 2023
commit dbfba5924a93666707503a4f096bb89512db97b1
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
strategy:
fail-fast: false
matrix:
node-version: [^18.18, ^20.3]
node-version: [^18.18, ^20.8]
os: [ubuntu-latest, windows-latest, macos-latest]
steps:
- uses: actions/checkout@v3
Expand Down
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
},
"type": "module",
"engines": {
"node": "^18.18 || ^20.3"
"node": "^18.18 || ^20.8"
},
"scripts": {
"test": "./scripts/test.sh"
Expand Down Expand Up @@ -151,6 +151,6 @@
}
},
"volta": {
"node": "20.3.1"
"node": "20.8.1"
}
}