Start work on breaking cyclic dependency #496

darioush · 2023-02-07T00:55:26Z

Why this should be merged

How this works

How this was tested

How is this documented

darioush

Could we also make sure the contract.StateDB interface is needed (I think it is, but worth checking)?
Other than that, mainly my comments are:

Not removing tests
Shorter names
Considering naming the precompile/config module precompileConfig since this is how it will be imported many places (other than precompiles)?
Ensure consistency of precompile code with each other and the template (eg, order of methods, ptr receiver vs. non-ptr receiver)

darioush · 2023-02-10T20:42:43Z

core/state_processor.go

+// - during block producing to apply the precompile upgrades before producing the block.
+func ApplyPrecompileActivations(c *params.ChainConfig, parentTimestamp *big.Int, blockContext contract.BlockContext, statedb *state.StateDB) error {
+	blockTimestamp := blockContext.Timestamp()
+	// Note: RegisteredModules returns precompiles in order they are registered.


I'd say we either order by key or by address.
Registration order may cause us trouble down the line if we eg, try to dynamically load modules.

sorted by addresses in #509

darioush · 2023-02-10T20:44:28Z

core/state_processor_test.go

-	config     = params.TestChainConfig
-	signer     = types.LatestSigner(config)
-	testKey, _ = crypto.HexToECDSA("b71c71a67e1177ad4e901695e1b4b9ee17ae16c6668d313eac2f96dbcda3f291")
+	chainConfig = params.TestChainConfig


nit: we can undo this rename.
I changed it but prefer to keep the import name as precompileConfig

i think it makes sense, we can keep it.

darioush · 2023-02-10T20:47:11Z

params/upgrade_config_test.go

@@ -1,285 +0,0 @@
-// (c) 2022, Ava Labs, Inc. All rights reserved.
-// See the file LICENSE for licensing terms.


could we bring back this test (and ensure this PR does not delete any other tests)

restored in #509

darioush · 2023-02-10T20:49:27Z

precompile/config/registry.go

+// params package
+// - IMPORTANT - cannot import precompile or statedb directly
+// imports precompile/config to unmarshal relevant configs and nothing else
+// this means that we also need to stop using AvalancheRules to hold the precompile contracts
+// switch instead to map address -> config
+// ActivePrecompiles was previously used to check if a precompile was enabled at that address, so we can still use this with the new map
+// also used in core/vm/evm.go to get the precompile contract
+// we will need to import the precompile/exec package to look up the precompile at that address now.
+
+// update package
+// import params package and precompile/exec
+// used to Configure precompiles


can we remove or improve this comment?

removed in #509

darioush · 2023-02-10T20:49:54Z

precompile/config/registry.go

+
+func GetConfigs() []Config { return configs }
+
+// TODO: add lookups as needed


nit: remove?

removed in #509

darioush · 2023-02-10T20:50:51Z

precompile/contracts/deployerallowlist/config.go

+// ContractDeployerAllowList with [admins] and [enableds] as members of the allowlist.
+func NewContractDeployerAllowListConfig(blockTimestamp *big.Int, admins []common.Address, enableds []common.Address) *ContractDeployerAllowListConfig {
+	return &ContractDeployerAllowListConfig{
+		AllowListConfig: allowlist.AllowListConfig{


We can improve these names so they don't stutter eg: AllowListConfig: allowlist.Config{...}

changed in #509

darioush · 2023-02-10T20:53:22Z

precompile/contracts/feemanager/module.go

+	return ConfigKey
+}
+
+// Address returns the address of the fee manager.


probably removing this comment makes the template gen. easier

removed in #509

darioush · 2023-02-10T20:54:16Z

precompile/contracts/nativeminter/config.go

@@ -50,66 +41,20 @@ func NewContractNativeMinterConfig(blockTimestamp *big.Int, admins []common.Addr
 // that disables ContractNativeMinter.
 func NewDisableContractNativeMinterConfig(blockTimestamp *big.Int) *ContractNativeMinterConfig {
 	return &ContractNativeMinterConfig{
-		UpgradeableConfig: precompile.UpgradeableConfig{
+		UpgradeableConfig: config.UpgradeableConfig{


wonder if we should simply call this config.Upgrade? and UpgradeConfig?

yep this is not an interface so able suffix does not really fit here. changed in #509

darioush · 2023-02-10T20:55:09Z

precompile/contracts/nativeminter/config.go

-// ConfigKey is the key used in json config files to specify this precompile config.
-// must be unique across all precompiles.
-const ConfigKey = "contractNativeMinterConfig"
+var _ config.Config = &ContractNativeMinterConfig{}


wonder if we could call this Config so externally it would be referenced as nativeminter.Config{}

renamed them in #509

* introduce precompiles as registrable modules * add precompile specific contract tests * remove print debug * add unmarshal tests * remove unnecessary func * fix initial disabled value * register all modules in core/evm/contract_stateful * more refactor & test fix * sync template * fix more tests * rename file * add comment * rename * fix linter * use require error contains * remove whitespace * trim mock interface * sort steps * reviews * Update precompile/stateful_precompile_module.go * Update params/precompile_config.go * Update params/precompile_config.go * fix reviews * add new module to configs and group module functions * generalized-upgrades-rb review (#474) * keep genesis disabled fix * nits * nits * nit * review fixes * Update precompile/allowlist/allowlist.go * use address in map * fix linter for embedded keys * update err messages * more err update * remove unnecessary function (#478) * Start work on breaking cyclic dependency (#496) * Update core/state_processor.go * fix reviews * Update precompile/contracts/txallowlist/contract_test.go * Generalized upgrades rb nits0 (#512) * Minor improvements * restore readOnly * more updates * Add back readOnly to allow list tests

* move inline string ABIs to separate files and embed them (#383) * move inline string ABIs to separate files and embed them * fix tests * fix tests * unexport function * Update accounts/abi/bind/bind.go Co-authored-by: Darioush Jalali <[email protected]> * fix func name Co-authored-by: Darioush Jalali <[email protected]> * replace getByKey with getByAddress (#395) * rework on panics in precompiles (#418) * rework on panics in precompiles * Update precompile/allow_list.go Co-authored-by: aaronbuchwald <[email protected]> * Update precompile/fee_config_manager.go Co-authored-by: aaronbuchwald <[email protected]> * Update precompile/fee_config_manager.go Co-authored-by: aaronbuchwald <[email protected]> * fix reviews * wrap errors in ConfigurePrecompiles * cleaner errors * Update utils.go * Update miner/worker.go Co-authored-by: aaronbuchwald <[email protected]> * Update core/state_processor.go Co-authored-by: aaronbuchwald <[email protected]> Co-authored-by: aaronbuchwald <[email protected]> * Precompile Specific Packages (#420) * rework on panics in precompiles * Update precompile/allow_list.go Co-authored-by: aaronbuchwald <[email protected]> * Update precompile/fee_config_manager.go Co-authored-by: aaronbuchwald <[email protected]> * Update precompile/fee_config_manager.go Co-authored-by: aaronbuchwald <[email protected]> * fix reviews * wrap errors in ConfigurePrecompiles * cleaner errors * move reward manager precompile to package (WIP) * rename files * fix abi path * move typecheck * move precompiles to their own packages * refactor precompile template * remove test file * upate comments * rm test files * new allowlist package * Update precompile/utils.go Co-authored-by: Darioush Jalali <[email protected]> * Update precompile/nativeminter/contract_native_minter.go Co-authored-by: Darioush Jalali <[email protected]> * Update precompile/nativeminter/contract_native_minter.go Co-authored-by: Darioush Jalali <[email protected]> * Update precompile/utils.go Co-authored-by: Darioush Jalali <[email protected]> * Update precompile/nativeminter/contract_native_minter.go Co-authored-by: Darioush Jalali <[email protected]> * fix nits Co-authored-by: aaronbuchwald <[email protected]> Co-authored-by: Darioush Jalali <[email protected]> * rename fee manager config struct (#427) * rename struct * rename fee config managers to fee managers * fix comments * Generalized upgrades rb (#434) * introduce precompiles as registrable modules * add precompile specific contract tests * remove print debug * add unmarshal tests * remove unnecessary func * fix initial disabled value * register all modules in core/evm/contract_stateful * more refactor & test fix * sync template * fix more tests * rename file * add comment * rename * fix linter * use require error contains * remove whitespace * trim mock interface * sort steps * reviews * Update precompile/stateful_precompile_module.go * Update params/precompile_config.go * Update params/precompile_config.go * fix reviews * add new module to configs and group module functions * generalized-upgrades-rb review (#474) * keep genesis disabled fix * nits * nits * nit * review fixes * Update precompile/allowlist/allowlist.go * use address in map * fix linter for embedded keys * update err messages * more err update * remove unnecessary function (#478) * Start work on breaking cyclic dependency (#496) * Update core/state_processor.go * fix reviews * Update precompile/contracts/txallowlist/contract_test.go * Generalized upgrades rb nits0 (#512) * Minor improvements * restore readOnly * more updates * Add back readOnly to allow list tests * Precompile improvements merge (#513) Co-authored-by: aaronbuchwald <[email protected]> Co-authored-by: Ceyhun Onur <[email protected]> Co-authored-by: Darioush Jalali <[email protected]> Co-authored-by: cam-schultz <[email protected]> Co-authored-by: Matthew Lam <[email protected]> Co-authored-by: cam-schultz <[email protected]> Co-authored-by: omahs <[email protected]> Co-authored-by: Anusha <[email protected]> Co-authored-by: Hagen Hübel <[email protected]> Co-authored-by: minghinmatthewlam <[email protected]> Fix: typos (#428) fix allow list comments (#469) fix CGO flags issue (#489) fix lint job (#499) * review fixes * minor nits * fix precompile generator * fix fee manager config test * remove debug files * Update core/state_processor.go Co-authored-by: aaronbuchwald <[email protected]> * fix comments * restore statedb ordering * fix configure in reward manager * precompiles: adds a regression test for the IsDisabled case in AvalancheRules (#515) * Rename configs: alternative (#520) * alternative renaming for precompile configs * fixes * update naming * rename to AllowListConfig * simplify * move blackhole check to module registerer (#523) * move blackhole check to module registerer * check blackhole first * add unit test * Add test case for registering module outside of reserved range --------- Co-authored-by: Aaron Buchwald <[email protected]> * precompile: improve test structure (#517) * refactor precompile tests * minor improvements * nit * fix merge * rename package * pr comments * rm file * merge AllowListTests * pr comments * explicit BeforeHook * wspace * Mark TestTransactionIndices flaky --------- Co-authored-by: Aaron Buchwald <[email protected]> * nit improvements (#529) * nit improvements * move comments to README * Update cmd/precompilegen/template-readme.md * Rename new config (#528) * rename configurator's new config to make config * use new built-in to create new config instance * precompile: just nits (#534)

@V3

* - Adding missing import "encoding/json" (used in Stringer-method) (ava-labs#465) - re-ordering of imports * fix allow list comments (ava-labs#469) * fix allow list comments * cleaner sentences * use preallocated big nums * infer allow list role type * add nil checks (ava-labs#473) * add nil checks * add unit test * use non nil config * use non-nil configs --------- Co-authored-by: aaronbuchwald <[email protected]> * Warp backend interface and implementation (ava-labs#452) * base warp backend * add signature caching * add docs * error handling * pr fixes * hash unsigned message for key * quick pr fixes and merge * save signature instead of whole msg * use avaGO cache * rename warpBackend and docs * fix nits * Update plugin/evm/warp_backend.go * Update plugin/evm/warp_backend.go * fix pr nits * pr fixes and testing * type check for caching * fix imports * use memdb and remove extra test * remove unused * fix imports * saving message in db and pr fixes * update copyright * update backend variable naming * add comment about saving db vs cache * Add documentation section to PR template (ava-labs#484) * remove current rules (ava-labs#481) Co-authored-by: Darioush Jalali <[email protected]> * add documentation guidelines (ava-labs#486) * add documentation guidelines * fix * parseInt from ENV var (ava-labs#491) * Add generate precompile script to fix CGO flags issue (ava-labs#489) * try to fix lint job (ava-labs#499) * build with avago v1.9.8 (ava-labs#498) * build with avago v1.9.8 * add indirect deps * build fix * another build fix * try to fix lint job * Signature Request Handler (ava-labs#459) Co-authored-by: aaronbuchwald <[email protected]> Co-authored-by: Darioush Jalali <[email protected]> * Update codeowners (ava-labs#492) Co-authored-by: Darioush Jalali <[email protected]> * Get signature endpoint: alternative PR with different packaging (ava-labs#507) * base warp backend * add signature caching * add docs * error handling * pr fixes * basic signature request * hash unsigned message for key * implement new Request and RequestHandler interfaces * signature handler impl without constructing one * fix import * quick pr fixes and merge * quick pr fixes and merge * save signature instead of whole msg * use avaGO cache * rename warpBackend and docs * fix nits * Update plugin/evm/warp_backend.go Co-authored-by: aaronbuchwald <[email protected]> * Update plugin/evm/warp_backend.go Co-authored-by: aaronbuchwald <[email protected]> * fix pr nits * pr fixes and testing * type check for caching * handlers and request before tests * fix imports * signature handler with stats and test * use memdb and remove extra test * remove unused * fix imports * fix imports * nit * update license year * use require noError * saving message in db and pr fixes * create noop signature handler and refactor code handler * get signature endpoint * add api arg to evm client * Update sync/handlers/handler.go Co-authored-by: aaronbuchwald <[email protected]> * update backend return value * refactor handlers to network handler * change constructor of handler stats * pr cleanups * warp api * initialize warp backend * build fix * wip * warp api follows eth api pattern * cleanup and comments * clean up response * fix warp client return type * nits for get-signature-endpoint (ava-labs#502) Co-authored-by: Darioush Jalali <[email protected]> Co-authored-by: aaronbuchwald <[email protected]> Co-authored-by: Ceyhun Onur <[email protected]> Co-authored-by: cam-schultz <[email protected]> * resolve merge conflict * warp: Group packages for symmetry w/ sync * more reshuffle * more shuffle * pr comments * fix * update to []byte * update svc return type * rename arg * fix type * add stats pkg --------- Co-authored-by: Matthew Lam <[email protected]> Co-authored-by: aaronbuchwald <[email protected]> Co-authored-by: cam-schultz <[email protected]> Co-authored-by: Ceyhun Onur <[email protected]> Co-authored-by: cam-schultz <[email protected]> * Update github actions to ignore rcs (ava-labs#521) * Remove unnecessary gasprice updater logic and tests (ava-labs#514) * Remove unnecessary gasprice updater logic and tests * Remove comment referencing gas price updater * Revert default price limit change * Move set min fee back to vm.go * Update to retain previous tx pool gas price setting behavior * Bump avalanchego to v1.9.9-rc.4 (ava-labs#526) * Bump avalanchego to v1.9.9-rc.4 * Fix imports * Bump compatibility.json for latest avalanchego release * Bump AvalancheGo dep to v1.9.9 (ava-labs#530) * Update AvalancheGo compatibility (ava-labs#531) * Start v0.4.10 release cycle (ava-labs#533) * Stateful Precompile Improvements (ava-labs#389) * move inline string ABIs to separate files and embed them (ava-labs#383) * move inline string ABIs to separate files and embed them * fix tests * fix tests * unexport function * Update accounts/abi/bind/bind.go Co-authored-by: Darioush Jalali <[email protected]> * fix func name Co-authored-by: Darioush Jalali <[email protected]> * replace getByKey with getByAddress (ava-labs#395) * rework on panics in precompiles (ava-labs#418) * rework on panics in precompiles * Update precompile/allow_list.go Co-authored-by: aaronbuchwald <[email protected]> * Update precompile/fee_config_manager.go Co-authored-by: aaronbuchwald <[email protected]> * Update precompile/fee_config_manager.go Co-authored-by: aaronbuchwald <[email protected]> * fix reviews * wrap errors in ConfigurePrecompiles * cleaner errors * Update utils.go * Update miner/worker.go Co-authored-by: aaronbuchwald <[email protected]> * Update core/state_processor.go Co-authored-by: aaronbuchwald <[email protected]> Co-authored-by: aaronbuchwald <[email protected]> * Precompile Specific Packages (ava-labs#420) * rework on panics in precompiles * Update precompile/allow_list.go Co-authored-by: aaronbuchwald <[email protected]> * Update precompile/fee_config_manager.go Co-authored-by: aaronbuchwald <[email protected]> * Update precompile/fee_config_manager.go Co-authored-by: aaronbuchwald <[email protected]> * fix reviews * wrap errors in ConfigurePrecompiles * cleaner errors * move reward manager precompile to package (WIP) * rename files * fix abi path * move typecheck * move precompiles to their own packages * refactor precompile template * remove test file * upate comments * rm test files * new allowlist package * Update precompile/utils.go Co-authored-by: Darioush Jalali <[email protected]> * Update precompile/nativeminter/contract_native_minter.go Co-authored-by: Darioush Jalali <[email protected]> * Update precompile/nativeminter/contract_native_minter.go Co-authored-by: Darioush Jalali <[email protected]> * Update precompile/utils.go Co-authored-by: Darioush Jalali <[email protected]> * Update precompile/nativeminter/contract_native_minter.go Co-authored-by: Darioush Jalali <[email protected]> * fix nits Co-authored-by: aaronbuchwald <[email protected]> Co-authored-by: Darioush Jalali <[email protected]> * rename fee manager config struct (ava-labs#427) * rename struct * rename fee config managers to fee managers * fix comments * Generalized upgrades rb (ava-labs#434) * introduce precompiles as registrable modules * add precompile specific contract tests * remove print debug * add unmarshal tests * remove unnecessary func * fix initial disabled value * register all modules in core/evm/contract_stateful * more refactor & test fix * sync template * fix more tests * rename file * add comment * rename * fix linter * use require error contains * remove whitespace * trim mock interface * sort steps * reviews * Update precompile/stateful_precompile_module.go * Update params/precompile_config.go * Update params/precompile_config.go * fix reviews * add new module to configs and group module functions * generalized-upgrades-rb review (ava-labs#474) * keep genesis disabled fix * nits * nits * nit * review fixes * Update precompile/allowlist/allowlist.go * use address in map * fix linter for embedded keys * update err messages * more err update * remove unnecessary function (ava-labs#478) * Start work on breaking cyclic dependency (ava-labs#496) * Update core/state_processor.go * fix reviews * Update precompile/contracts/txallowlist/contract_test.go * Generalized upgrades rb nits0 (ava-labs#512) * Minor improvements * restore readOnly * more updates * Add back readOnly to allow list tests * Precompile improvements merge (ava-labs#513) Co-authored-by: aaronbuchwald <[email protected]> Co-authored-by: Ceyhun Onur <[email protected]> Co-authored-by: Darioush Jalali <[email protected]> Co-authored-by: cam-schultz <[email protected]> Co-authored-by: Matthew Lam <[email protected]> Co-authored-by: cam-schultz <[email protected]> Co-authored-by: omahs <[email protected]> Co-authored-by: Anusha <[email protected]> Co-authored-by: Hagen Hübel <[email protected]> Co-authored-by: minghinmatthewlam <[email protected]> Fix: typos (ava-labs#428) fix allow list comments (ava-labs#469) fix CGO flags issue (ava-labs#489) fix lint job (ava-labs#499) * review fixes * minor nits * fix precompile generator * fix fee manager config test * remove debug files * Update core/state_processor.go Co-authored-by: aaronbuchwald <[email protected]> * fix comments * restore statedb ordering * fix configure in reward manager * precompiles: adds a regression test for the IsDisabled case in AvalancheRules (ava-labs#515) * Rename configs: alternative (ava-labs#520) * alternative renaming for precompile configs * fixes * update naming * rename to AllowListConfig * simplify * move blackhole check to module registerer (ava-labs#523) * move blackhole check to module registerer * check blackhole first * add unit test * Add test case for registering module outside of reserved range --------- Co-authored-by: Aaron Buchwald <[email protected]> * precompile: improve test structure (ava-labs#517) * refactor precompile tests * minor improvements * nit * fix merge * rename package * pr comments * rm file * merge AllowListTests * pr comments * explicit BeforeHook * wspace * Mark TestTransactionIndices flaky --------- Co-authored-by: Aaron Buchwald <[email protected]> * nit improvements (ava-labs#529) * nit improvements * move comments to README * Update cmd/precompilegen/template-readme.md * Rename new config (ava-labs#528) * rename configurator's new config to make config * use new built-in to create new config instance * precompile: just nits (ava-labs#534) * fix e2e comment in readme (ava-labs#540) * fix config template for precompilegen (ava-labs#538) * fix config template for precompilegen * nits * nit * nits * Update compatibility in README for v0.4.10 (ava-labs#542) * Bump minimum golang version to v1.20.1 (ava-labs#548) * Bump minimum golang version to 1.20.1 * Remove debug flag from gh action release * add whitespace (ava-labs#544) Co-authored-by: aaronbuchwald <[email protected]> * Set minimum golang version to go1.19.6 (ava-labs#551) * add custom marshaller for GetChainConfigResponse api (ava-labs#546) * add yet another custom marshaller to GetChainConfigResponse api * enforce a json len before allocation * Move chain config wrapper type to params/ and add test * Fix trailing newline * Remove flaky unit test * Add back unit test with JSONeq --------- Co-authored-by: Darioush Jalali <[email protected]> Co-authored-by: aaronbuchwald <[email protected]> * Start coreth migration (ava-labs#552) * Start coreth migration * Bump version to v0.4.11 and avalanchego dep * goimports core/blockchain.go * Update compatibility.json * Update compatibility in README * Bump avalanchego dep to v1.9.10 * Start release cycle v0.4.12 (ava-labs#559) * start v0.4.12 release cycle * add setup action to lint ci for proper go version * Bump version in plugin/evm/version.go * Remove go version pin * Revert "Remove go version pin" This reverts commit e651beb. * bump golangci-lint-acion to @V3 * bump golangci lint * try 1.48 * golangci-lint v1.51 and goimports leveldb file * migrate linting changes from coreth * goimports and fix diagram comments * Fix bad goimports changes --------- Co-authored-by: Darioush Jalali <[email protected]> * remove stderr pipelining (ava-labs#562) * Add ChainConfig JSON Unmarshaller (ava-labs#554) * add unmarshaller * add comments * Update codeql to v2 (ava-labs#566) * state modifications as network upgrade (ava-labs#549) Co-authored-by: Aaron Buchwald <[email protected]> * Fix Dockerfile and add Build Image to GH Actions (ava-labs#561) * Remove specified git version to avoid downgrades breaking docker build * Add build docker image to unit test action * Update to use current branch instead of commit for docker image build * Update docker image script to push image if env var is set * Add new line to build image script * Update scripts/constants.sh Co-authored-by: Sam Batschelet <[email protected]> * Update docker login * Update build image action * Update gh action * checkout for docker image build * Set build image ID in gh action with github.ref_name * Separate CI and release * remove extra copy * Update name * Update variable used in build image id * Update set var * Update dockerhub repo * Revert dockerhub repo name chnge and use Subnet-EVM in tag name --------- Co-authored-by: Sam Batschelet <[email protected]> * add compatibility to readme (ava-labs#568) * Precompile pre post handling (ava-labs#524) * Re-apply warp precompile interface changes * Address nits * Separate predicate storage slot preparation into separate function in statedb * fix lint * improve miner enforcePredicates comment * Add HashSliceToBytes test case for empty slice * Address comments * Address comments WIP * Pre+post handling diff for shared mem precompile * Separate proposer and general precompile predicates * Update ShouldVerifyWithContext to return true iff proposer predicate is specified * Add checkPredicates unit test * Update .gitignore * goimports * update * goimports config * Address PR review comments and improve comments * Fix typo * Address PR comments * Add rules into PrepareAccessList * Only copy bytes in preparePredicates if predicate precompile is active * Address PR comments --------- Co-authored-by: Darioush Jalali <[email protected]> * Warp preparation (ava-labs#573) * Add warp precompile preparation * Update hash slice packing * Remove unnecessary local var * Add VM type assertion * Enable Warp API by default * convert from int->uint for more clarity (ava-labs#575) * release tickers on shutdown (ava-labs#574) * release tickers on shutdown * move shutdownWg.done to other defer block * simplify functionSignatureRegex (ava-labs#578) * Remove unused imgs from repo (ava-labs#580) * Matches go-ethereum/pull/26912/files (ava-labs#582) * Add ignore unnecessary import to precompile contract template (ava-labs#581) * trie, accounts/abi: nits: adds err checks (ava-labs#583) * Adds a test for PeerTracker (ava-labs#576) * upgrade avalanche go and add logs * update avalanche go version * add gotenv and get env variables from .env file * Revert "add gotenv and get env variables from .env file" This reverts commit 87b0007. * refactoring * upgrade avalanche go to v1.9.14 * use GRPC_ prefix in env variable to inject env variables --------- Co-authored-by: Hagen Hübel <[email protected]> Co-authored-by: Ceyhun Onur <[email protected]> Co-authored-by: aaronbuchwald <[email protected]> Co-authored-by: minghinmatthewlam <[email protected]> Co-authored-by: Darioush Jalali <[email protected]> Co-authored-by: cam-schultz <[email protected]> Co-authored-by: cam-schultz <[email protected]> Co-authored-by: Patrick O'Grady <[email protected]> Co-authored-by: Sam Batschelet <[email protected]>

aaronbuchwald and others added 12 commits February 3, 2023 16:14

Start work on breaking cyclic dependency

1a66b9b

WIP

768fa4e

fix compile and put back the rest of the code

1d8740e

fixes

975aa7c

more wip

69ae341

minor nits

7ad9e20

fix nonce bug

4a5380c

move tests to specific packages

9ad562d

move precompile processing to processor

a2f925f

more cleanup

1274e79

move precompiles to sub package

c2f7a40

rename files

dc40156

ceyonur marked this pull request as ready for review February 10, 2023 15:46

ceyonur requested review from ceyonur, patrick-ogrady and aaronbuchwald as code owners February 10, 2023 15:46

ceyonur marked this pull request as draft February 10, 2023 15:49

aaronbuchwald added precompile cleanup labels Feb 10, 2023

darioush commented Feb 10, 2023

View reviewed changes

wip (#509)

12a58d9

ceyonur marked this pull request as ready for review February 14, 2023 16:38

Merge branch 'generalized-upgrades-rb' into break-cyclic-x

543a48e

ceyonur merged commit acf4f9e into generalized-upgrades-rb Feb 14, 2023

ceyonur deleted the break-cyclic-x branch February 14, 2023 17:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Start work on breaking cyclic dependency #496

Start work on breaking cyclic dependency #496

darioush commented Feb 7, 2023

darioush left a comment

darioush Feb 10, 2023

ceyonur Feb 14, 2023

darioush Feb 10, 2023

ceyonur Feb 14, 2023

darioush Feb 10, 2023

ceyonur Feb 14, 2023

darioush Feb 10, 2023

ceyonur Feb 14, 2023

darioush Feb 10, 2023

ceyonur Feb 14, 2023

darioush Feb 10, 2023

ceyonur Feb 14, 2023

darioush Feb 10, 2023

ceyonur Feb 14, 2023

darioush Feb 10, 2023

ceyonur Feb 14, 2023

darioush Feb 10, 2023

ceyonur Feb 14, 2023

		@@ -1,285 +0,0 @@
		// (c) 2022, Ava Labs, Inc. All rights reserved.
		// See the file LICENSE for licensing terms.


		func GetConfigs() []Config { return configs }

		// TODO: add lookups as needed

Start work on breaking cyclic dependency #496

Start work on breaking cyclic dependency #496

Conversation

darioush commented Feb 7, 2023

Why this should be merged

How this works

How this was tested

How is this documented

darioush left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment