Replace gopkg.in/auth0.v5 with github.com/auth0/go-auth0 #395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergiught
force-pushed
the
patch/go-auth0
branch
from
ce30fd9
to
b8e1f71
Compare
sergiught
commented
Feb 23, 2022
| // | ||
| // https://auth0.com/docs/api/management/v2/#!/Actions/get_triggers | ||
| ListTriggers(opts ...management.RequestOption) (l *management.ActionTriggerList, err error) | ||
| Triggers(opts ...management.RequestOption) (l *management.ActionTriggerList, err error) |
There was a problem hiding this comment.
The ListTriggers has been deprecated in favor of Triggers. The func signature remains the same.
| // | ||
| // See: https://auth0.com/docs/api/management/v2/#!/Organizations/patch_organizations_by_id | ||
| Update(o *management.Organization, opts ...management.RequestOption) error | ||
| Update(id string, o *management.Organization, opts ...management.RequestOption) error |
There was a problem hiding this comment.
The signature of this func has changed within the Go SDK to better align how all CRUD funcs behave.
| @@ -201,7 +202,7 @@ auth0 actions create --n myaction -t post-login -d "lodash=4.0.0" -s "API_KEY=va | |||
|
|
|||
| action := &management.Action{ | |||
| Name: &inputs.Name, | |||
| SupportedTriggers: []management.ActionTrigger{ | |||
| SupportedTriggers: []*management.ActionTrigger{ | |||
There was a problem hiding this comment.
This has also been changed to a slice of pointers within the Go SDK.
| } | ||
|
|
||
| if isAnyColorSet { | ||
| o.Branding.Colors = map[string]string{} | ||
| o.Branding.Colors = map[string]interface{}{} |
There was a problem hiding this comment.
This has also changed within the Go SDK, however the underlying field values remain strings. That's why further down we cast again to .(string).
sergiught
force-pushed
the
patch/go-auth0
branch
from
b8e1f71
to
c797de0
Compare
willvedd
approved these changes
Feb 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR replaces gopkg.in/auth0.v5 (github.com/go-auth0/auth0) with github.com/auth0/go-auth0 as we now have brought the SDK within the Auth0 org.
Checklist
master