Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(parser): Add LaTeX support #726

Merged
merged 13 commits into from
Mar 4, 2021
Merged

Conversation

neotyk
Copy link
Collaborator

@neotyk neotyk commented Mar 3, 2021

closes #575

@CLAassistant
Copy link

CLAassistant commented Mar 3, 2021

CLA assistant check
All committers have signed the CLA.

@tangjeff0
Copy link
Collaborator

Recommend linting/styling/testing locally. It's faster than waiting for CI. https://github.com/athensresearch/athens/blob/master/CONTRIBUTING.md#running-ci-scripts-locally

@neotyk
Copy link
Collaborator Author

neotyk commented Mar 3, 2021

Can't seem to satisfy lint and style checks at the same time.

@tangjeff0
Copy link
Collaborator

Ah, yeah, that happens sometimes when importing npm packages, which use quotes. Guessing kondo and cljstyle look at the quotes differently.

Something like this might fix it: https://github.com/athensresearch/athens/blob/master/src/cljs/athens/views/graph_page.cljs#L1

Otherwise, I can take a look at this tomorrow. Functionality more important than linting.

@neotyk
Copy link
Collaborator Author

neotyk commented Mar 3, 2021

I've unnecessarily upgraded cljstyle. Let me know I can revert it.

@tangjeff0 tangjeff0 changed the title Add LaTeX support enhance(parser): Add LaTeX support Mar 4, 2021
@tangjeff0 tangjeff0 merged commit 3a3fb1f into athensresearch:master Mar 4, 2021
korlaism pushed a commit to korlaism/athens that referenced this pull request Jul 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Latex Maths
3 participants