Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add contributing section to the community heading (#405) #415

Merged
merged 3 commits into from
Oct 27, 2021

Conversation

boyney123
Copy link
Contributor

Description

Following conversations over on #405, I thought this might be a nice addition to the website.

Somewhere people can click and start to explore how they can contribute to AsyncAPI projects.

At the moment this PR points to the Contributing GitHub Readme file that @alequetzalli has done.

I think the GitHub README file explains pretty nicely how to contribute, so maybe we can keep the context there but just point there from this link.

Anyway, let me know what you think @alequetzalli to the change 🙇

Sceenshot

image

@netlify
Copy link

netlify bot commented Oct 8, 2021

✔️ Deploy Preview for asyncapi-website ready!
Built without sensitive environment variables

🔨 Explore the source changes: a5a1a59

🔍 Inspect the deploy log: https://app.netlify.com/sites/asyncapi-website/deploys/6179185cf739440007016b87

😎 Browse the preview: https://deploy-preview-415--asyncapi-website.netlify.app

@boyney123 boyney123 changed the title Adding contributing section to the community heading (#405) feat: Adding contributing section to the community heading (#405) Oct 8, 2021
@boyney123 boyney123 changed the title feat: Adding contributing section to the community heading (#405) feat: adding contributing section to the community heading (#405) Oct 11, 2021
@boyney123
Copy link
Contributor Author

Any thoughts on this one @derberg @alequetzalli? I think it's a nice touch, maybe copy needs reviewing, but dunno what you think?

Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might be good but now I see we are missing a link to https://github.com/asyncapi/community/blob/master/CONTRIBUTING.md in the place where you want to link

@boyney123
Copy link
Contributor Author

might be good but now I see we are missing a link to asyncapi/community@master/CONTRIBUTING.md in the place where you want to link

At the moment I'm linking to this place

image

@derberg are you saying you would prefer to link to https://github.com/asyncapi/community/blob/master/CONTRIBUTING.md instead?

Or are you saying that the Org README is missing the link to https://github.com/asyncapi/community/blob/master/CONTRIBUTING.md?

@derberg
Copy link
Member

derberg commented Oct 15, 2021

I choose answer number 2? did I win? 😄

@boyney123
Copy link
Contributor Author

I choose answer number 2? did I win? 😄

Think so 🤣

@derberg
Copy link
Member

derberg commented Oct 27, 2021

@boyney123 I think we can merge this one. I opened a fix for readme here asyncapi/.github#95

just update to master I guess, make sure all ready and I can merge

@boyney123
Copy link
Contributor Author

All good to go @derberg 🚀

@derberg derberg changed the title feat: adding contributing section to the community heading (#405) feat: add contributing section to the community heading (#405) Oct 27, 2021
@derberg derberg merged commit cba802f into asyncapi:master Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants