Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: added uniform padding around the on this page header #3249

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ManasMalla
Copy link

On this docs page, on smaller device breakpoints, the On this page becomes a sticky header which breaks the uniform padding used through out the website, which has been fixed in this PR.

Resolves #3248

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

Copy link

netlify bot commented Sep 23, 2024

Deploy Preview for asyncapi-website ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 4fea44e
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-website/deploys/66f28d059861740008df97ab
😎 Deploy Preview https://deploy-preview-3249--asyncapi-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@asyncapi-bot
Copy link
Contributor

asyncapi-bot commented Sep 23, 2024

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 42
🟢 Accessibility 98
🟢 Best practices 92
🟢 SEO 100
🔴 PWA 33

Lighthouse ran on undefined

@devilkiller-ag
Copy link
Member

@ManasMalla Follow proper PR title according to the Contributing Guideline.

@ManasMalla ManasMalla changed the title added uniform padding around the on this page header [style] added uniform padding around the on this page header Sep 24, 2024
@ManasMalla ManasMalla changed the title [style] added uniform padding around the on this page header style: added uniform padding around the on this page header Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Responsiveness on padding on documentation below md
3 participants