Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update-financial-year #3198

Closed
wants to merge 2 commits into from

Conversation

Rohank1442
Copy link

No description provided.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

Copy link

netlify bot commented Sep 6, 2024

Deploy Preview for asyncapi-website ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 4d18200
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-website/deploys/66db5f035cc9ab0008522779
😎 Deploy Preview https://deploy-preview-3198--asyncapi-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@asyncapi-bot
Copy link
Contributor

asyncapi-bot commented Sep 6, 2024

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 33
🟢 Accessibility 98
🟢 Best practices 92
🟢 SEO 100
🔴 PWA 33

Lighthouse ran on https://deploy-preview-3198--asyncapi-website.netlify.app/

@Rohank1442 Rohank1442 changed the title update-financial-year fix: update-financial-year Sep 6, 2024
@JeelRajodiya
Copy link
Contributor

JeelRajodiya commented Sep 7, 2024

Hello @Rohank1442, the PR for this issue already exists, please check #2687

@Rohank1442
Copy link
Author

Hello @Rohank1442, the PR for this issue already exists, please check #2687

I thought the issue wasn't solved as @sambhavgupta0705 commented that it was still relevant.

@JeelRajodiya
Copy link
Contributor

JeelRajodiya commented Sep 7, 2024

Hello @Rohank1442, the PR for this issue already exists, please check #2687

I thought the issue wasn't solved as @sambhavgupta0705 commented that it was still relevant.

I think, the "still relevant" was commented there for the bot so it will remove the stale label

@sambhavgupta0705
Copy link
Member

closing this as duplicate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants