Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: responsiveness issue with github button #3009

Closed
wants to merge 2 commits into from

Conversation

NightFury742
Copy link

Description
The Github button is now perfectly aligned and spaced with the view docs button at /tools/generator route

image

Related issue(s)
Resolves #3008

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

Copy link

netlify bot commented May 30, 2024

Deploy Preview for asyncapi-website ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit f3b5916
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-website/deploys/6697f7a89e5f5d000826ec81
😎 Deploy Preview https://deploy-preview-3009--asyncapi-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@NightFury742 NightFury742 changed the title fix: Responsiveness issue with github button fix: responsiveness issue with github button May 30, 2024
@asyncapi-bot
Copy link
Contributor

asyncapi-bot commented May 30, 2024

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 31
🟢 Accessibility 98
🟢 Best practices 92
🟢 SEO 100
🟠 PWA 56

Lighthouse ran on https://deploy-preview-3009--asyncapi-website.netlify.app/

@sambhavgupta0705
Copy link
Member

/update

Copy link
Member

@sambhavgupta0705 sambhavgupta0705 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sambhavgupta0705
Copy link
Member

@NightFury742 for now I am closing this PR as this issue is coming up again and again so we will think of an ideal solution for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Responsiveness issue on the View on Github button
3 participants