Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding unit tests for typography component #1793

Merged
merged 4 commits into from
Jun 17, 2023

Conversation

reachaadrika
Copy link
Contributor

@reachaadrika reachaadrika commented Jun 15, 2023

Description

  • Typography in AsyncAPI includes 3 main components :

  • Heading : This component has heading which has props like 'typeStyle' and 'textColor' , and levels , which when we pass to heading when required we can change it accordingly .
    Here are the tests I have included for this component :

  1. renders the heading with the default props
  2. renders the heading with custom props

NOTE : For this component I have not included 'data-testids' since testing was required for specific level tag headings and already passed props .

image
image

  • Paragraph : This component also has some textStyle and textColor Props .
    The tests I have included here are as follows :
  1. renders the paragraph with the default props
  2. renders the paragraph with custom props
    image
    image
  • TextLink : For this component the tests I have included are as follows :
  1. renders a link with the provided props and contentpassed

image

Related issue(s)
fixes #1792

@netlify
Copy link

netlify bot commented Jun 15, 2023

Deploy Preview for asyncapi-website ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit df7be53
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-website/deploys/648d61ae0fd3c50008cc9867
😎 Deploy Preview https://deploy-preview-1793--asyncapi-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

github-actions bot commented Jun 15, 2023

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 61
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🔴 PWA 30

Lighthouse ran on https://deploy-preview-1793--asyncapi-website.netlify.app/

@akshatnema akshatnema added the gsoc This label should be used for issues or discussions related to ideas for Google Summer of Code label Jun 16, 2023
@akshatnema
Copy link
Member

/rtm

@asyncapi-bot asyncapi-bot merged commit 0b0ab18 into asyncapi:master Jun 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gsoc This label should be used for issues or discussions related to ideas for Google Summer of Code ready-to-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add tests for Typography component
3 participants