-
-
Notifications
You must be signed in to change notification settings - Fork 589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: persist filters as URL query params on Tools page #1497
feat: persist filters as URL query params on Tools page #1497
Conversation
✅ Deploy Preview for asyncapi-website ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-1497--asyncapi-website.netlify.app/ |
ff52c70
to
ce89c8d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Olaleye-Blessing thanks for creating PR for the issue. Here are certain issues you have to resolve:
These subheadings shouldn't get centered. Kindly make them left aligned with the block.
d300e14
to
5d71e7b
Compare
I don't know how this happened since I didn't touch the styling. |
/rtm |
Description
Users lose the filter options whenever they refresh the tools page. This is because the options are being saved in states.
With this PR, users can now refresh the page and still have their filter options available.
Related issue(s)
Closes: #1312