Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: cli validation tutorial steps #1370

Closed

Conversation

Aysha-py
Copy link

Description
I added the tutorial steps, summary, and next step to the Validation steps using CLI

image

image

Related issue(s)
Related issue(s)
Fixes #1094

@netlify
Copy link

netlify bot commented Feb 26, 2023

Deploy Preview for asyncapi-website ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit bf8a842
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-website/deploys/6461472acf7e2f0008995e76
😎 Deploy Preview https://deploy-preview-1370--asyncapi-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Aysha-py Aysha-py changed the title Cli validation tutorial steps docs: cli validation tutorial steps Feb 26, 2023
@github-actions
Copy link

github-actions bot commented Feb 26, 2023

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 28
🟠 Accessibility 88
🟢 Best practices 100
🟢 SEO 100
🔴 PWA 30

Lighthouse ran on https://deploy-preview-1370--asyncapi-website.netlify.app/

@quetzalliwrites quetzalliwrites added 📑 docs area/docs Specify what technical area given issue relates to. Its goal is to ease filtering good first issues. labels Feb 26, 2023
@quetzalliwrites
Copy link
Member

  1. what is this PR for? and why does it seem like a duplicate of docs: tutorial - validate asyncapi document with cli #1341?
  2. why did you copy/paste the ENTIRE cli installation info to this PR? CLI docs are not relevant to this tutorial 😄

@Aysha-py
Copy link
Author

Hi @alequetzalli, from our subsequent conversations, there was a comment where you said I can find the installation guide in the cli repo and I should add it to my PR. I might have missed the instruction as this is what I followed.

Do you mean I have to install the CLI on my PC?

Since this is my first time writing a tutorial related to Validating the document using CLI, is there a document or file that helps me understand how to do this?

If I am not taking too much of your time on this, I'd appreciate clarity on this.

@quetzalliwrites
Copy link
Member

Hi @alequetzalli, from our subsequent conversations, there was a comment where you said I can find the installation guide in the cli repo and I should add it to my PR. I might have missed the instruction as this is what I followed.

Do you mean I have to install the CLI on my PC?

Since this is my first time writing a tutorial related to Validating the document using CLI, is there a document or file that helps me understand how to do this?

If I am not taking too much of your time on this, I'd appreciate clarity on this.

No worries! So no, you are not writing a tutorial about installing the CLI, you are writing a tutorial about validating docs with the CLI.

Correct, you asked me for info on how to install the CLI and I sent you to the repo. But you downloading the CLI in your dev env is not related to writing this tutorial.

Let me know if you got it now :)

@Aysha-py
Copy link
Author

Aysha-py commented Apr 6, 2023

Thank you for your reply @alequetzalli. Now I understand, Can I get a document to help me understand how to validate docs using AsynAPi so that I can update the tutorial, if you don't mind, I would love general feedback on the commit I have made so far.

Thank you

@quetzalliwrites
Copy link
Member

Thank you for your reply @alequetzalli. Now I understand, Can I get a document to help me understand how to validate docs using AsynAPi so that I can update the tutorial...

@derberg what is the best resource I (we) can give @Aysha-py in order for her to understand how to validate docs with the CLI? Do we have something already written up to share with her and maybe I am unaware? 😬😄✌🏽

@quetzalliwrites
Copy link
Member

@Aysha-py It is too early for me to review your draft because you must complete the entire task before I conduct an editorial review. That said, please remember you need to clean this file up and remove the content you added regarding how to install the CLI. That is NOT part of this tutorial, so you need to remove that :)

@Aysha-py
Copy link
Author

The tutorial part will be removed, In the meantime, I await @derberg's answer on the resources.

Copy link
Member

derberg commented May 11, 2023

@derberg what is the best resource I (we) can give @Aysha-py in order for her to understand how to validate docs with the CLI?

the best is to install CLI, grab asyncapi document and run asyncapi validate against it 😃

@quetzalliwrites
Copy link
Member

@Aysha-py You must remove the wrong content from THIS pull request. You shouldn't be opening a new pull request to make changes to this one; that doesn't make any sense. Also you didn't remove any content, you just added an HTML comment. Please make sure to delete wrong content, not comment it out.

@Aysha-py
Copy link
Author

@Aysha-py You must remove the wrong content from THIS pull request. You shouldn't be opening a new pull request to make changes to this one; that doesn't make any sense. Also you didn't remove any content, you just added an HTML comment. Please make sure to delete wrong content, not comment it out.

Thank you @alequetzalli, I would do this and make sure not to open a new pull request. I actually though I needed to make new PRs for corrections.

@Aysha-py
Copy link
Author

@derberg what is the best resource I (we) can give @Aysha-py in order for her to understand how to validate docs with the CLI?

the best is to install CLI, grab asyncapi document and run asyncapi validate against it 😃

Thank you @derberg.

Copy link

github-actions bot commented Mar 9, 2024

This pull request has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this pull request, add a comment with detailed explanation.

There can be many reasons why some specific pull request has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this pull request forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@github-actions github-actions bot added the stale label Mar 9, 2024
@github-actions github-actions bot closed this Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docs Specify what technical area given issue relates to. Its goal is to ease filtering good first issues. 📑 docs stale
Projects
Status: Community PR under Review 🧐
Development

Successfully merging this pull request may close these issues.

[📑 Docs]: new tutorial 'validate AsyncAPI document with CLI'
3 participants