chore: unlink roadmap from shape-up-process repo #1208
Conversation
fmvilas
requested review from
derberg,
mcturco,
akshatnema,
magicmatatjahu and
asyncapi-bot-eve
as code owners
✅ Deploy Preview for asyncapi-website ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-1208--asyncapi-website.netlify.app/ |
| @@ -9,7 +10,7 @@ export default function RoadmapItem({ | |||
| collapsed = true, | |||
| }) { | |||
| const [isCollapsed, setIsCollapsed] = useState(collapsed) | |||
| const isCollapsible = item.solutions || item.bets | |||
| const isCollapsible = item.solutions || item.implementations | |||
There was a problem hiding this comment.
Since we're not using the Shape Up framework anymore, I'm calling this implementations, which are a combination of repos, issues, or pull requests.
| </div> | ||
| </div> | ||
| </div> | ||
| </GenericLayout> | ||
| ) | ||
| } | ||
|
|
||
| const solutions = { |
There was a problem hiding this comment.
The data powering the roadmap is here. Not perfect but very handy :)
There was a problem hiding this comment.
I don't have a problem with this code, but if it is to be updated once every 3 months wouldn't it be better to do it in the form of a yaml file - you don't have to do it now but it's my suggestion to make it easier to update the content on the roadmap in the future. WDYT? :)
There was a problem hiding this comment.
I don't think so. Having it here lets me have JSX code in the descriptions, which is very helpful.
There was a problem hiding this comment.
@fmvilas Overall, the changes are perfect ✨. Just that, can you name Modal.js to anything like RoadmapModal.js because many of the components in the folder are Modal? So, by naming this, we can easily get where this modal is exactly being used.
|
@akshatnema Actually the Modal.js implementation is agnostic from the roadmap on purpose so that we can reuse it in other places. Otherwise, we'll end up with many different types of modals. I'd just keep this name and we can create another issue to migrate all modals to this one (or an evolution of this one). |
|
@magicmatatjahu good catch. Added a description to the last three items and Escape key handler to the modal. @akshatnema please re-approve if you still agree with the changes 🙏 |
|
/rtm |
As a result of this discussion, the shape-up-process repo that's powering the asyncapi.com/roadmap page is going to be deleted (actually moved to github.com/asyncapi-archived-repos). Therefore, I'm removing the "link" and hardcoding the roadmap here.
My plan is to revisit this roadmap every quarter (dreams 😅) so I'll be taking care of it.