feat: add subscribe form to meetings and tsc page #1026

fmvilas · 2022-10-17T15:50:46Z

It adds a subscription form to the /community/meetings page. I've configured (still on it while opening this PR) Mailchimp to tag users as "meetings-email" so we know exactly which of them should be receiving the weekly meetings email.

Not sure there's a related issue. It's been a long-awaited feature by @derberg (along with the TSC members voting email, which will come next).

EDIT:

It also eliminates the need to pass a formName param to the NewsletterSubscribe component. We'll always use the same because Zapier/Netlify integration is done by form. This means we need to create a Zap per form and Zapier charges per Zap. Since we're not interested in which form was used, I'm always using the same form name, and the routing will happen based on the type field (e.g., jobs, meetings-email, etc.). If no type is provided, it will just be understood as you're subscribing to the newsletter, as usual.

EDIT 2:

I'm also adding the TSC voting form on the /community/tsc page, so people can get notified when someone requests the TSC to vote.

Check after merge

List of interests show TSC voting email and Meetings email. See feat: add subscribe form to meetings and tsc page #1026 (review) for context.

netlify · 2022-10-17T15:50:51Z

✅ Deploy Preview for asyncapi-website ready!

Name	Link
🔨 Latest commit	`59b82d4`
🔍 Latest deploy log	https://app.netlify.com/sites/asyncapi-website/deploys/63580f160039260008011553
😎 Deploy Preview	https://deploy-preview-1026--asyncapi-website.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

github-actions · 2022-10-17T15:53:48Z

⚡️ Lighthouse report for the changes in this PR:

Category	Score
🔴 Performance	43
🟠 Accessibility	88
🟠 Best practices	83
🟢 SEO	90
🔴 PWA	30

Lighthouse ran on https://deploy-preview-1026--asyncapi-website.netlify.app/

derberg

😍

So as I understand, when we send email about meetings it is still going to be:

            recipients: {
                list_id: '6e3e437abe',
                segments_opts: {
                    saved_segment_id: 'meetings-email'
                }
            }

now, in case of TSC, we should send to:

            recipients: {
                list_id: '6e3e437abe',
                segments_opts: {
                    saved_segment_id: 'tsc-voting-email'
                }
            }

so still the same list, just different segment. Right?

There is no GH issue on that. I just figured that we need it when you made changes in lists, as you noticed some people unsubscribed when we started sending "meetings updates". I never created an issue as anyway only you have rights to modify Mailchimp and Zapier that we already have in place.

When I want to update my Mailchimp preferences I see:

Can we change it to AsyncAPI?

Then, when I finally get a link, in update I see only

but I see meetings and tsc too, right?

Just to confirm, you wanna also extend https://github.com/asyncapi/community/blob/master/.github/workflows/notify-tsc-members-mention.yml to send email to Mailchimp, or you leave it to me?

pages/blog/2020-summary.md

pages/community/tsc.js

fmvilas · 2022-10-20T04:19:05Z

So as I understand, when we send email about meetings it is still going to be:

            recipients: {
                list_id: '6e3e437abe',
                segments_opts: {
                    saved_segment_id: 'meetings-email'
                }
            }

now, in case of TSC, we should send to:

            recipients: {
                list_id: '6e3e437abe',
                segments_opts: {
                    saved_segment_id: 'tsc-voting-email'
                }
            }

so still the same list, just different segment. Right?

Yes, if I understood Mailchimp API correctly, that's the case.

Then, when I finally get a link, in update I see only
but I see meetings and tsc too, right?

I'm not quite sure but that's something we can test after it's merged. If it doesn't work, I'd just have to tweak it on Mailchimp so no problem.

Just to confirm, you wanna also extend https://github.com/asyncapi/community/blob/master/.github/workflows/notify-tsc-members-mention.yml to send email to Mailchimp, or you leave it to me?

I'll leave it up to you. Maybe someone else can help? @KhudaDad414, you're familiar with Github Actions, maybe you can help?

All feedback is addressed now @derberg. Please review it again.

akshatnema · 2022-10-21T14:27:49Z

pages/newsletter/index.js

@@ -13,7 +13,7 @@ export default function NewsletterIndexPage() {
      </StickyNavbar>
      <div className="py-12 mt-12">
        <Container wide>
-          <NewsletterSubscribe formName="form 1" />
+          <NewsletterSubscribe />


@fmvilas I am slightly concerned about why we are making the newsletter a separate route on the website. We aren't using this route anywhere in the website, not in the navbar or footer as well. We can simply have NewsletterSubscribe as a component and can be used in various places as needed. So, can we remove this file?

@akshatnema this is meant to be referenced externally (emails, slides, etc.). It's a landing page.

@akshatnema it was there before, it is for tweets and other stuff that @fmvilas mentioned. So you do not send people to asyncapi.com and make them look for newsletter subscription component, but just send them to https://asyncapi.com/newsletter

derberg · 2022-10-25T14:38:58Z

@fmvilas regarding how it looks like in Mailchimp
I think it can only be done in the Mailchimp, the "update of preferences"
this PR has nothing to do with it.

you can check with https://gmail.us12.list-manage.com/profile/send-email

derberg · 2022-10-25T14:42:54Z

@fmvilas can you also check something in Mailchimp. Not sure how you, but I did not receive an email this week (Monday) about the meetings from this week but in CI I can see that campaign was created in mailchimp

fmvilas · 2022-10-25T16:09:19Z

@fmvilas regarding how it looks like in Mailchimp I think it can only be done in the Mailchimp, the "update of preferences" this PR has nothing to do with it.

you can check with https://gmail.us12.list-manage.com/profile/send-email

I don't get what you're talking about 🤔 Also, the link doesn't work for me.

@fmvilas can you also check something in Mailchimp. Not sure how you, but I did not receive an email this week (Monday) about the meetings from this week but in CI I can see that campaign was created in mailchimp

I did receive the email 🤔 I wonder what failed.

derberg

all is clear

I did not get email as I unsubscribed and then subscribed back, but it was when meeting subscription was not yet possible.

Thanks mate!!!

I created followup issue for TSC notifications -> https://github.com/asyncapi/community/issues/503

fmvilas · 2022-10-25T16:54:44Z

/rtm

fmvilas · 2022-10-25T16:59:31Z

Oh yeah, I'm editing a Markdown file so I need approval from @alequetzalli :)

feat: add subscribe form to meetings page

ff0401e

fmvilas requested a review from quetzalliwrites October 17, 2022 15:50

fmvilas requested review from derberg, mcturco, akshatnema, magicmatatjahu and asyncapi-bot-eve as code owners October 17, 2022 15:50

fmvilas added 2 commits October 17, 2022 18:32

Always use form 1 to minimize cost

1fd4f8b

Add TSC voting form

3a5cdc1

fmvilas changed the title ~~feat: add subscribe form to meetings page~~ feat: add subscribe form to meetings and tsc page Oct 17, 2022

derberg requested changes Oct 18, 2022

View reviewed changes

pages/blog/2020-summary.md Show resolved Hide resolved

pages/community/tsc.js Outdated Show resolved Hide resolved

Move TSC form before members list

c8c2e6e

akshatnema reviewed Oct 21, 2022

View reviewed changes

Remove job forms in articles

dc346c0

fmvilas requested review from derberg and akshatnema October 24, 2022 15:01

Merge branch 'master' into add-meetings-subscribe-form

59b82d4

derberg approved these changes Oct 25, 2022

View reviewed changes

asyncapi-bot added the ready-to-merge label Oct 25, 2022

quetzalliwrites approved these changes Oct 25, 2022

View reviewed changes

quetzalliwrites merged commit ad56b22 into asyncapi:master Oct 25, 2022

fmvilas deleted the add-meetings-subscribe-form branch October 25, 2022 17:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add subscribe form to meetings and tsc page #1026

feat: add subscribe form to meetings and tsc page #1026

fmvilas commented Oct 17, 2022 •

edited

Loading

netlify bot commented Oct 17, 2022 •

edited

Loading

github-actions bot commented Oct 17, 2022 •

edited

Loading

derberg left a comment

fmvilas commented Oct 20, 2022

akshatnema Oct 21, 2022

fmvilas Oct 24, 2022

derberg Oct 25, 2022

derberg commented Oct 25, 2022

derberg commented Oct 25, 2022

fmvilas commented Oct 25, 2022

derberg left a comment

fmvilas commented Oct 25, 2022

fmvilas commented Oct 25, 2022

feat: add subscribe form to meetings and tsc page #1026

feat: add subscribe form to meetings and tsc page #1026

Conversation

fmvilas commented Oct 17, 2022 • edited Loading

Check after merge

netlify bot commented Oct 17, 2022 • edited Loading

✅ Deploy Preview for asyncapi-website ready!

github-actions bot commented Oct 17, 2022 • edited Loading

derberg left a comment

Choose a reason for hiding this comment

but I see meetings and tsc too, right?

fmvilas commented Oct 20, 2022

akshatnema Oct 21, 2022

Choose a reason for hiding this comment

fmvilas Oct 24, 2022

Choose a reason for hiding this comment

derberg Oct 25, 2022

Choose a reason for hiding this comment

derberg commented Oct 25, 2022

derberg commented Oct 25, 2022

fmvilas commented Oct 25, 2022

derberg left a comment

Choose a reason for hiding this comment

fmvilas commented Oct 25, 2022

fmvilas commented Oct 25, 2022

fmvilas commented Oct 17, 2022 •

edited

Loading

netlify bot commented Oct 17, 2022 •

edited

Loading

github-actions bot commented Oct 17, 2022 •

edited

Loading