Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve spectra arithmetic #998

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Improve spectra arithmetic #998

wants to merge 4 commits into from

Conversation

pllim
Copy link
Member

@pllim pllim commented Dec 1, 2022

TST: Add a test case that fails
currently but should pass when code is implemented.

Also refactored some tests for arithmetic.
@pllim pllim marked this pull request as ready for review December 2, 2022 03:14
@pllim pllim added this to the v2.0 milestone Dec 2, 2022
@pllim
Copy link
Member Author

pllim commented Dec 2, 2022

I don't think the remote data failure is related. It has something to do with this file that I didn't touch.

https://data.sdss.org/sas/dr8/sdss/spectro/redux/26/0273/spPlate-0273-51957.fits

@rosteen rosteen requested review from nmearl and eteq December 2, 2022 13:47
@pllim
Copy link
Member Author

pllim commented Dec 23, 2022

If we ever come back to this, need to also consider the implication of astropy/astropy#13977

@pllim
Copy link
Member Author

pllim commented Apr 19, 2023

Is there still interest to pursue this or should I just close it without merge?

@rosteen
Copy link
Contributor

rosteen commented Apr 19, 2023

Yes, there's still interest, but I milestoned it to 2.0 so I haven't been in a rush to get it in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

arithmetic operations don't check compatibility of spectral_axis
2 participants