Change "toolchain" to "python" #4735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanieb
force-pushed
the
zb/toolchain-python
branch
3 times, most recently
from
3c76810
to
f0e90fd
Compare
zanieb
commented
Jul 2, 2024
Comment on lines
+103
to
+116
| // Support `toolchains` -> `python` migration transparently. | ||
| if !root.exists() | ||
| && root | ||
| .parent() | ||
| .is_some_and(|parent| parent.join("toolchains").exists()) | ||
| { | ||
| let deprecated = root.parent().unwrap().join("toolchains"); | ||
| // Move the deprecated directory to the new location. | ||
| fs::rename(&deprecated, root)?; | ||
| // Create a link or junction to at the old location | ||
| uv_fs::replace_symlink(root, &deprecated)?; | ||
| } else { | ||
| fs::create_dir_all(root)?; | ||
| } |
|
I'll give this diff a careful read through as well. |
charliermarsh
approved these changes
Jul 2, 2024
|
My only complaint is that |
|
Yeah I agree that's a little confusing and my primary hesitation. What if we provide a |
|
Curious, would there be a different short-hand for this similar to uvx? Say |
|
I think similar to |
zanieb
force-pushed
the
zb/toolchain-python
branch
from
f0e90fd
to
198cdcc
Compare
zanieb
force-pushed
the
zb/toolchain-python
branch
from
198cdcc
to
7e9f6c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whew this is a lot.
The user-facing changes are:
uv toolchaintouv pythone.g.uv python find,uv python install, ...UV_TOOLCHAIN_DIRtoUV_PYTHON_INSTALL_DIR<UV_STATE_DIR>/toolchainsto<UV_STATE_DIR>/python(with automatic migration)The internal changes are:
uv-toolchaincrate touv-pythonToolchainno longer referenced in type namesSystemPythontype (previously replaced)