Skip to content
This repository has been archived by the owner on Dec 14, 2018. It is now read-only.

Parameter in IHtmlHelper.TextBox() has an inconsistent parameter name #5394

Closed
dougbu opened this issue Oct 11, 2016 · 2 comments
Closed

Parameter in IHtmlHelper.TextBox() has an inconsistent parameter name #5394

dougbu opened this issue Oct 11, 2016 · 2 comments

Comments

@dougbu
Copy link
Member

dougbu commented Oct 11, 2016

Problem introduced in 8eb6327 which was (of course) intended to "Make HTML helper parameter names consistent".

The IHtmlHelper.TextBox() method has the following signature

IHtmlContent TextBox(string current, object value, string format, object htmlAttributes);

All other methods in the IHtmlHelper interface use expression for parameters with the same purpose as current. TextBox() extensions in HtmlHelperInputExtensions also have expression parameters. IHtmlHelper.TextBox() is the only oddball.

Can we take the slight breaking change to fix this sooner than 2.0?

@Eilon
Copy link
Member

Eilon commented Oct 17, 2016

We can fix in 2.0.0.

@dougbu
Copy link
Member Author

dougbu commented Mar 27, 2017

6436538

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants