Check for empty location in ViewsFeatureProvider

Fixes #5675
aspnet · Jan 17, 2017 · e749a80 · e749a80
1 parent ce53675
commit e749a80
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 1 deletion.
diff --git a/src/Microsoft.AspNetCore.Mvc.Razor/Compilation/ViewsFeatureProvider.cs b/src/Microsoft.AspNetCore.Mvc.Razor/Compilation/ViewsFeatureProvider.cs
@@ -58,7 +58,7 @@ public void PopulateFeature(IEnumerable<ApplicationPart> parts, ViewsFeature fea
         protected virtual Type GetViewInfoContainerType(AssemblyPart assemblyPart)
         {
 #if NETSTANDARD1_6
-            if (!assemblyPart.Assembly.IsDynamic && assemblyPart.Assembly.Location != null)
+            if (!assemblyPart.Assembly.IsDynamic && !string.IsNullOrEmpty(assemblyPart.Assembly.Location))
             {
                 var precompiledAssemblyFileName = assemblyPart.Assembly.GetName().Name
                     + PrecompiledViewsAssemblySuffix

diff --git a/test/Microsoft.AspNetCore.Mvc.Razor.Test/Compilation/ViewsFeatureProviderTest.cs b/test/Microsoft.AspNetCore.Mvc.Razor.Test/Compilation/ViewsFeatureProviderTest.cs
@@ -90,6 +90,23 @@ public void PopulateFeature_ReturnsEmptySequenceIfNoDynamicAssemblyPartHasViewAs
             Assert.Empty(feature.Views);
         }
 
+        [Fact]
+        public void PopulateFeature_DoesNotFail_IfAssemblyHasEmptyLocation()
+        {
+            // Arrange
+            var assembly = new AssemblyWithEmptyLocation();
+            var applicationPartManager = new ApplicationPartManager();
+            applicationPartManager.ApplicationParts.Add(new AssemblyPart(assembly));
+            applicationPartManager.FeatureProviders.Add(new ViewsFeatureProvider());
+            var feature = new ViewsFeature();
+
+            // Act
+            applicationPartManager.PopulateFeature(feature);
+
+            // Assert
+            Assert.Empty(feature.Views);
+        }
+
         private class TestableViewsFeatureProvider : ViewsFeatureProvider
         {
             private readonly Dictionary<AssemblyPart, Type> _containerLookup;
@@ -125,5 +142,12 @@ public ViewInfoContainer2()
             {
             }
         }
+
+        private class AssemblyWithEmptyLocation : Assembly
+        {
+            public override string Location => string.Empty;
+
+            public override string FullName => typeof(ViewsFeatureProviderTest).GetTypeInfo().Assembly.FullName;
+        }
     }
 }