Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TimeSpan overloads to SqlServer DateDiff function #15810

Merged
merged 1 commit into from
Jun 1, 2019
Merged

Add TimeSpan overloads to SqlServer DateDiff function #15810

merged 1 commit into from
Jun 1, 2019

Conversation

Muppets
Copy link
Contributor

@Muppets Muppets commented May 26, 2019

Summary of the changes

  • Added TimeSpan overloads to DateDiffHour, DateDiffMinute, DateDiffSecond, DateDiffMillisecond, DateDiffMicrosecond, DateDiffNanosecond
  • Added unit tests to check overloads

Fixes #14685

@Muppets
Copy link
Contributor Author

Muppets commented May 26, 2019

Most of this work was based on the code from WhitWaldo's commit.

@Muppets Muppets force-pushed the 14685-DateDiffSecond-does-not-accept-TimeSpan branch from abf3dcf to 0d6eb34 Compare May 29, 2019 19:53
@Muppets Muppets force-pushed the 14685-DateDiffSecond-does-not-accept-TimeSpan branch from 69548ef to 89576fc Compare May 29, 2019 20:39
@Muppets
Copy link
Contributor Author

Muppets commented May 29, 2019

@smitpatel, @maumar This should be good to go. Let me know if you need any changes.

@smitpatel smitpatel mentioned this pull request May 31, 2019
Closed
4 tasks
@maumar maumar merged commit 89576fc into dotnet:master Jun 1, 2019
@maumar
Copy link
Contributor

maumar commented Jun 1, 2019

@Muppets I have merged the PR. Thank you for the contribution!

@Muppets Muppets deleted the 14685-DateDiffSecond-does-not-accept-TimeSpan branch June 2, 2019 14:19
@ajcvickers ajcvickers mentioned this pull request Jun 6, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smitpatel smitpatel smitpatel left review comments

@maumar maumar maumar left review comments

Assignees

@maumar maumar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DateDiffSecond does not accept TimeSpan
3 participants
@Muppets @maumar @smitpatel