Skip to content

Commit

Permalink
Fix incorrect event name docs
Browse files Browse the repository at this point in the history
Updated event naming in docs from "collection:rendered" -> "render:collection" along with the associated "on" version of the event (i.e. onRenderCollection vs onCollectionRendered)
Updated event naming in source comments docs from "child:added" -> "add:child"
  • Loading branch information
ryno1234 authored and samccone committed Jan 15, 2015
1 parent 937e095 commit ccff995
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion docs/marionette.collectionview.md
Original file line number Diff line number Diff line change
Expand Up @@ -498,7 +498,7 @@ myView.render();
### "render" event
A "collection:rendered" / `onCollectionRendered` event will also be fired. This allows you to
A "render:collection" / `onRenderCollection` event will also be fired. This allows you to
add more than one callback to execute after the view is rendered,
and allows parent views and other parts of the application to
know that the view was rendered.
Expand Down
2 changes: 1 addition & 1 deletion src/collection-view.js
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,7 @@ Marionette.CollectionView = Marionette.View.extend({
},

// Render and show the emptyView. Similar to addChild method
// but "child:added" events are not fired, and the event from
// but "add:child" events are not fired, and the event from
// emptyView are not forwarded
addEmptyView: function(child, EmptyView) {

Expand Down

0 comments on commit ccff995

Please sign in to comment.