Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make more structs derive PartialEq/Eq/Hash #248

Merged

Conversation

swooster
Copy link
Contributor

Adds equality-related traits to VkClearRect, VkOffset2D, VkOffset3D,
VkRect2D and VkSurfaceFormatKHR. Fixes a typo preventing said traits
from being applied to VkExtent2D.

@swooster
Copy link
Contributor Author

swooster commented Nov 11, 2019

NOTE: I haven't regenerated vk.rs because when I try to do that it comes out without newlines. (Maybe because I'm on Windows?) If somebody else is able to get that working, I'd be grateful. (EDIT: the commit was updated to include vk.rs)

@swooster swooster force-pushed the swooster/make-more-structs-derive-eq-traits branch from 3175c8f to fcb752a Compare November 11, 2019 19:39
@Ralith
Copy link
Collaborator

Ralith commented Nov 11, 2019

I haven't regenerated vk.rs because when I try to do that it comes out without newlines.

This is the expected behavior; the workflow is to run cargo fmt after regenerating.

@aloucks
Copy link
Contributor

aloucks commented Nov 11, 2019

I use core.autocrlf=input even on Windows and I think rustfmt will fallback to use native line endings if it can't detect any in the file (and I think the generated vk.rs is all on one line).

Not sure if this will help your specific case, but I leave an uncommitted rustfmt.toml in my ash directory:

newline_style = "Unix"

Adds equality-related traits to VkClearRect, VkOffset2D, VkOffset3D,
VkRect2D and VkSurfaceFormatKHR. Fixes a typo preventing said traits
from being applied to VkExtent2D.
@swooster swooster force-pushed the swooster/make-more-structs-derive-eq-traits branch from fcb752a to 9522eb4 Compare November 11, 2019 21:00
@swooster
Copy link
Contributor Author

Ok, thanks for the explanation. I've pushed a version of the commit with changes to vk.rs included.

Copy link
Collaborator

@Ralith Ralith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants