Skip to content

Commit

Permalink
tps65090-charger: Use "IS_ENABLED(CONFIG_OF)" for DT code
Browse files Browse the repository at this point in the history
Instead of "#if defined(CONFIG_OF)" use "IS_ENABLED(CONFIG_OF)" option
for DT code to avoid if-deffery in code.

Also, arranged header files in alphabetically.

Signed-off-by: Manish Badarkhe <[email protected]>
Acked-by: Rhyland Klein <[email protected]>
Signed-off-by: Anton Vorontsov <[email protected]>
  • Loading branch information
mbadarkhe authored and enomsg committed Oct 25, 2013
1 parent 0ed8139 commit e47bcba
Showing 1 changed file with 5 additions and 14 deletions.
19 changes: 5 additions & 14 deletions drivers/power/tps65090-charger.c
Original file line number Diff line number Diff line change
Expand Up @@ -15,15 +15,17 @@
* You should have received a copy of the GNU General Public License
* along with this program. If not, see <http://www.gnu.org/licenses/>.
*/
#include <linux/delay.h>
#include <linux/err.h>
#include <linux/init.h>
#include <linux/interrupt.h>
#include <linux/kernel.h>
#include <linux/module.h>
#include <linux/slab.h>
#include <linux/delay.h>
#include <linux/of_device.h>
#include <linux/platform_device.h>
#include <linux/power_supply.h>
#include <linux/slab.h>

#include <linux/mfd/tps65090.h>

#define TPS65090_REG_INTR_STS 0x00
Expand Down Expand Up @@ -185,10 +187,6 @@ static irqreturn_t tps65090_charger_isr(int irq, void *dev_id)
return IRQ_HANDLED;
}

#if defined(CONFIG_OF)

#include <linux/of_device.h>

static struct tps65090_platform_data *
tps65090_parse_dt_charger_data(struct platform_device *pdev)
{
Expand All @@ -210,13 +208,6 @@ static struct tps65090_platform_data *
return pdata;

}
#else
static struct tps65090_platform_data *
tps65090_parse_dt_charger_data(struct platform_device *pdev)
{
return NULL;
}
#endif

static int tps65090_charger_probe(struct platform_device *pdev)
{
Expand All @@ -228,7 +219,7 @@ static int tps65090_charger_probe(struct platform_device *pdev)

pdata = dev_get_platdata(pdev->dev.parent);

if (!pdata && pdev->dev.of_node)
if (IS_ENABLED(CONFIG_OF) && !pdata && pdev->dev.of_node)
pdata = tps65090_parse_dt_charger_data(pdev);

if (!pdata) {
Expand Down

0 comments on commit e47bcba

Please sign in to comment.