Skip to content
This repository has been archived by the owner on Mar 18, 2022. It is now read-only.

Update ttml2str #158

Merged
merged 5 commits into from
Apr 29, 2020
Merged

Update ttml2str #158

merged 5 commits into from
Apr 29, 2020

Conversation

arvvoid
Copy link
Owner

@arvvoid arvvoid commented Apr 27, 2020

Please check that your pull request pass this checks:

  • My changes respect the Kodi add-on development rules
  • My code is both Python 2 and 3 compatible
  • My code follows the code style of this project (PEP8, long lines allowed if make sense)
  • I made sure there wasn't another Pull Request opened for the same update/change
  • I have successfully tested my changes locally

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Adding a new region/hbo go version

Description:

Fix issue #157

@arvvoid

This comment has been minimized.

@arvvoid
Copy link
Owner Author

arvvoid commented Apr 27, 2020

@rocknrollnor New test version is ready, should be ok, please test and let me know.

@arvvoid
Copy link
Owner Author

arvvoid commented Apr 27, 2020

@arvvoid
Copy link
Owner Author

arvvoid commented Apr 28, 2020

@rocknrollnor Ping, not sure if you noticed new test version :)

@arvvoid
Copy link
Owner Author

arvvoid commented Apr 29, 2020

Hello, @Sakerdot @sanangel @PolliSoft @macardi @jhdgghost @jumakki @Evili84 @haakobja if someone has some free time I would like to ask some help in testing this.

@rocknrollnor
Copy link

It works :)

@arvvoid
Copy link
Owner Author

arvvoid commented Apr 29, 2020

@rocknrollnor ok perfect. So the problem with subtitles is gone as well in the mentioned titles in the issue?

@rocknrollnor
Copy link

Yes

@arvvoid
Copy link
Owner Author

arvvoid commented Apr 29, 2020

Ok, I will tag the issue as fixed.
Now I just need someone that can, to test this on a recent build of Kodi 19 (alpha, test only on isolated test device/virtual machine) and then I can merge this and release.

@arvvoid arvvoid marked this pull request as ready for review April 29, 2020 10:33
@arvvoid arvvoid merged commit 94f16bb into master Apr 29, 2020
@arvvoid arvvoid deleted the update_ttml2str branch April 29, 2020 20:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working Testers wanted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants