Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: click replacing review_app command with review-app #298

Merged
merged 1 commit into from
Apr 25, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ tests:

test:
coverage run --omit="test/*" -m unittest discover test.unit
coverage run --omit="test/*" -m unittest discover test.smoke

integration:
coverage run --omit="test/*" -m unittest discover test.integration
Expand Down
2 changes: 1 addition & 1 deletion hokusai/cli/review_app.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
from hokusai.lib.common import set_verbosity, CONTEXT_SETTINGS, clean_string
from hokusai.lib.config import HOKUSAI_CONFIG_DIR, config

@base.group()
@base.group('review_app')
def review_app(context_settings=CONTEXT_SETTINGS):
"""Create/Manage review apps"""
pass
Expand Down
3 changes: 3 additions & 0 deletions test/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -28,3 +28,6 @@ class HokusaiUnitTestCase(HokusaiTestCase):

class HokusaiIntegrationTestCase(HokusaiTestCase):
pass

class HokusaiSmokeTestCase(HokusaiTestCase):
pass
Empty file added test/smoke/__init__.py
Empty file.
13 changes: 13 additions & 0 deletions test/smoke/test_review_app.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
from click.testing import CliRunner
from hokusai.cli.base import base
from test import HokusaiSmokeTestCase

class TestReviewApp(HokusaiSmokeTestCase):
def test_review_app_with_underscore(self):
runner = CliRunner()
result = runner.invoke(base, ['review_app'])
assert result.exit_code == 0
def test_review_app_with_dash(self):
runner = CliRunner()
result = runner.invoke(base, ['review-app'])
assert result.exit_code != 0