Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STV should use first-round total for vote percent #509

Merged
merged 2 commits into from
Sep 30, 2024
Merged

Conversation

artoonie
Copy link
Owner

No description provided.

@artoonie artoonie force-pushed the stv-fix-percentage branch 4 times, most recently from 8a31ab5 to 70ab8f8 Compare September 30, 2024 18:40
Copy link

codecov bot commented Sep 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.79%. Comparing base (b03d1b2) to head (46a1791).
Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #509      +/-   ##
==========================================
+ Coverage   96.77%   96.79%   +0.02%     
==========================================
  Files         121      121              
  Lines        5799     5805       +6     
==========================================
+ Hits         5612     5619       +7     
+ Misses        187      186       -1     
Flag Coverage Δ
96.79% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
visualizer/graph/graphSummary.py 98.68% <100.00%> (+0.07%) ⬆️
visualizer/sankey/graphToD3.py 100.00% <100.00%> (ø)
visualizer/tabular/tabular.py 99.46% <100.00%> (+<0.01%) ⬆️
visualizer/tests/testSimple.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b03d1b2...46a1791. Read the comment docs.

@artoonie artoonie merged commit 423e152 into main Sep 30, 2024
8 checks passed
@artoonie artoonie deleted the stv-fix-percentage branch September 30, 2024 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant