Support native builds on Windows with MinGW/UCRT #1104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it looks like Fasta.cpp doesn't actually use mmap.h? Regardless, can't hurt to be conservative
Signed-off-by: Andrew Robbins <[email protected]>
causes issues w/ mingw
Co-authored-by: Valeriu Ohan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unlike the previous MSYS PR, which requires cygwin/msys's C library, this is an honest to god port of bedtools2 to the windows C runtime.
Some tests will fail when run in minpty but will work perfectly fine when run from a windows conpty, not entirely sure the best way to fix that. Additionally, the makefile doesn't actually install the libraries alongside the executable, which is...kind of important.
Aside from that, its late and I'll be online tomorrow.