Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cli): add darwin arm64 to build and release #2264

Merged
merged 1 commit into from
Sep 27, 2022

Conversation

zachaller
Copy link
Collaborator

@zachaller zachaller commented Sep 26, 2022

Signed-off-by: zachaller [email protected]

@sonarcloud
Copy link

sonarcloud bot commented Sep 26, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
2.6% 2.6% Duplication

@zachaller zachaller added the ready-for-review Ready for final review label Sep 26, 2022
@zachaller zachaller marked this pull request as ready for review September 26, 2022 15:49
@github-actions
Copy link
Contributor

Go Published Test Results

1 769 tests   1 769 ✔️  2m 34s ⏱️
   101 suites         0 💤
       1 files           0

Results for commit f245088.

@codecov
Copy link

codecov bot commented Sep 26, 2022

Codecov Report

Base: 82.34% // Head: 82.36% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (f245088) compared to base (ae56d91).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2264      +/-   ##
==========================================
+ Coverage   82.34%   82.36%   +0.01%     
==========================================
  Files         121      121              
  Lines       18438    18438              
==========================================
+ Hits        15183    15186       +3     
+ Misses       2469     2466       -3     
  Partials      786      786              
Impacted Files Coverage Δ
rollout/templateref.go 82.98% <0.00%> (+1.54%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

E2E Tests Published Test Results

  1 files    1 suites   54m 55s ⏱️
89 tests 80 ✔️ 3 💤 6
95 runs  86 ✔️ 3 💤 6

For more details on these failures, see this check.

Results for commit f245088.

Copy link
Member

@rbreeze rbreeze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@leoluz leoluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leoluz leoluz merged commit 417aaa6 into argoproj:master Sep 27, 2022
jenciso pushed a commit to jenciso/argo-rollouts that referenced this pull request Oct 25, 2022
jandersen-plaid pushed a commit to jandersen-plaid/argo-rollouts that referenced this pull request Nov 8, 2022
jandersen-plaid pushed a commit to jandersen-plaid/argo-rollouts that referenced this pull request Nov 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-review Ready for final review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants