fix: FeedbackDataset fields with required=False failing on push_to_huggingface
#4006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frascuchon
reviewed
Oct 20, 2023
src/argilla/client/feedback/integrations/huggingface/dataset.py
Outdated
Show resolved
Hide resolved
frascuchon
reviewed
Oct 20, 2023
Co-authored-by: Francisco Aranda <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
📢 Thoughts on this report? Let us know!. |
|
The URL of the deployed environment for this PR is https://argilla-quickstart-pr-4006-ki24f765kq-no.a.run.app |
frascuchon
approved these changes
Oct 20, 2023
damianpumar
pushed a commit
that referenced
this pull request
Oct 24, 2023
…to_huggingface` (#4006) # Description This PR addresses an issue reported by @dvsrepo, that was preventing from uploading a `FeedbackDataset` to the Hugging Face Hub via `push_to_huggingface` when there were any optional fields not provided. **Type of change** - [x] Bug fix (non-breaking change which fixes an issue) **How Has This Been Tested** - [x] Add unit tests for `FeedbackDataset` with optional i.e. `required=False` fields **Checklist** - [x] I followed the style guidelines of this project - [x] I did a self-review of my code - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [ ] I filled out [the contributor form](https://tally.so/r/n9XrxK) (see text above) - [ ] I have added relevant notes to the `CHANGELOG.md` file (See https://keepachangelog.com/) --------- Co-authored-by: Francisco Aranda <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses an issue reported by @dvsrepo, that was preventing from uploading a
FeedbackDatasetto the Hugging Face Hub viapush_to_huggingfacewhen there were any optional fields not provided.Type of change
How Has This Been Tested
FeedbackDatasetwith optional i.e.required=FalsefieldsChecklist
CHANGELOG.mdfile (See https://keepachangelog.com/)