Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Remove unused advanced dsl #3861

Merged
merged 4 commits into from
Oct 12, 2023
Merged

chore: Remove unused advanced dsl #3861

merged 4 commits into from
Oct 12, 2023

Conversation

frascuchon
Copy link
Member

@frascuchon frascuchon commented Sep 29, 2023 •
edited
Loading

Description

This PR removes the unused advanced dsl extension since it is not being used and it was not documented

Checklist

  • I added relevant documentation
  • I followed the style guidelines of this project
  • I did a self-review of my code
  • I made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I filled out the contributor form (see text above)
  • I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)

@frascuchon frascuchon merged commit 0aa6736 into develop Oct 12, 2023
14 of 16 checks passed
@frascuchon frascuchon deleted the chore/remove-luqum-dependency branch October 12, 2023 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dvsrepo dvsrepo dvsrepo approved these changes

@gabrielmbmb gabrielmbmb Awaiting requested review from gabrielmbmb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@frascuchon @dvsrepo